njzhangyifei / msys2-mingw-shortcut-menus Goto Github PK

Hello,

Thanks for contributing very nice stuff.

For me, it only works under shell path instead for example:

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\Software\Classes\Directory\shell\msys2]
@="MSYS2 Bash Here"
"Icon"="\"C:\\msys64\\msys2.ico\""

[HKEY_LOCAL_MACHINE\Software\Classes\Directory\shell\msys2\command]
@="C:\\msys64\\msys2_shell.cmd -msys -where \"%v\""

After removing the Background from the path, it works well.

The new 2016.05-2 update of filesystem breaks the functionality, since all start scripts got unified:

WARNING: the shell starting scripts have been unified. Please update your
shortcuts to the following targets, otherwise they will STOP WORKING:

• MSYS2_ROOT\msys2_shell.cmd -mingw32
• MSYS2_ROOT\msys2_shell.cmd -mingw64
• MSYS2_ROOT\msys2_shell.cmd -msys

however just replacing the scripts in the code with the new script and the argument doesn't seem to work, I guess the new script handles the arguments differently.

Since msys2 been upgrade for more environments
https://www.msys2.org/docs/environments/
Please consider add UCRT64, CLANG64, etc...

This script is no problem with blank space such as "Program Files", but if the directory's name has & character, such as "x&y", this script will failed.
"/usr/bin/bash: 第 0 行: cd: C:\Users\Nero\Desktop\x: No such file or directory
"
environment: windows 10 x64, msys2 x86_64

There is a missing backslash in both the path to icon and path to the cmd file to launch the shell.
It should be (example) C:\\msys64\msys2.ico, but generated C:\\msys64msys2.ico
It should be (example) C:\\msys64\msys2_shell.cmd, but generated C:\\msys64msys2_shell.cmd

usage step 3:
./install and follow the instructions
You should say use what shell.

cmd can not excute ./install.
And I have installed git-bash, the easiest way is use right click menu git-bash(embed mingw64) to execute ./install.
But I afraid this would add another git-bash(embed mingw64).
I'd like use another independent mingw64(I install another one) because git-bash'smingw64 is less function.

But I don't know how to do,
mingw64(I intalled ) do not have a exe like cmd.exe, I can't figure out how to use mingw64(I intalled ) to excute ./install

Regarding the instruction:

0. Make sure environment variable %HOME% exists. (This script will source %HOME%/.bash_profile)

Should the variable %HOME% actually be $HOME ?

Cheers,

It works fine in Windows Explorer, But in TC the Shortcut is missing.
Please Help.Thanks.

谢谢作者，您是**人吧。
在Windows的资源管理器下点右键可以看到快捷方式，但在TC的窗口里，按右键并不能出现快捷方式，请问有解决方法吗？

"git clone" through ssh needs ssh permission
git clone [email protected]:njzhangyifei/msys2-mingw-shortcut-menus.git

and it will work well cloning via https
git clone https://github.com/njzhangyifei/msys2-mingw-shortcut-menus.git

Today after the "pacman -Syu"
the mingw64_shell.bat content is changed:

:
@echo off

rem To activate windows native symlinks uncomment next line
rem set MSYS=winsymlinks:nativestrict

rem Set debugging program for errors
rem set MSYS=error_start:%WD%../../mingw64/bin/qtcreator.exe^|-debug^|^<process-id^>

rem To export full current PATH from environment into MSYS2 uncomment next line
rem set SET_FULL_PATH=1

call "%~dp0start_shell.cmd" -mingw64 %*
:EOF

it seems it call the script "start_shell.cmd" instead and old script is not workded anymore.

Thanks for fixing this issue! :)