nmwael / slurry Goto Github PK

In the currently available 1.0-SNAPSHOT version there is no way to configure 
ttl, but the site says otherwise.

_Potentially_, the org.slurry.quartz4guice.scheduling.ScheduleFactoryProvider 
can produce more than one org.quartz.SchedulerFactory instance, since ro each 
org.slurry.quartz4guice.scheduling.ScheduleFactoryProvider#get() call it 
creates a new SchedulerFactory instance.
Please see attached patch.

Change 
private String getCacheName(MethodInvocation invocation) {
    return invocation.getMethod().toString();
  }

private String getCacheName(MethodInvocation invocation) {
    return invocation.getMethod().getClass()+" "+ 
invocation.getMethod().toString();
  }

There's no need to to extend org.slurry.quartz4guice.module.ScheduleModule to 
specify the Provider<SchedulerFactory> has to be used, you can simply use 
constructors.
See attached patch

There are some missing org.quartz.JobDetail parameters that can be easily 
customized using  Quartz4Guice annotation, please see the attached patch.
It has to be applied at quartz4guice root

What steps will reproduce the problem?
1. Add Slurry release repository to project's pom.xml

<repository>
  <id>slurry-release</id>
  <name>Slurry Release</name>
  <url>http://slurry.googlecode.com/svn/maven/release</url>
</repository>

2. Specify cache4guice as dependency

<dependency>
  <groupId>org.slurry</groupId>
  <artifactId>cache4guice</artifactId>
  <version>1.0.7</version>
</dependency>

3. mvn clean install


What is the expected output? What do you see instead?

Expected: build successful
Instead: Project ID: org.slurry:cache4guice:jar:1.0.7
Reason: Cannot find parent: org.slurry:slurryparent for project: 
org.slurry:cache4guice:jar:1.0.7 for project org.slurry:cache4guice:jar:1.0.7


What version of the product are you using? On what operating system?

maven2 on Ubuntu 12.04

I guess that 
http://slurry.googlecode.com/svn/maven/release/org/slurry/cache4guice/1.0.7/cach
e4guice-1.0.7.pom contains wrong parent version that should not end with 
"SNAPSHOT" as it is Maven *release* repoository.

<parent>
  <artifactId>slurryparent</artifactId>
  <groupId>org.slurry</groupId>
  <relativePath>../../pom.xml</relativePath>
  <version>1.0-SNAPSHOT</version>
</parent>

My workaround:

/**
 * {@code CacheKeyGenerator} implementation that avoids Slurry's {@code StringBasedKeyGenerator}
 * null pointer exceptions on null key fields.
 */
public class StringCacheKeyGenerator extends BaseKeyGenerator {

  @Override
  protected String getKey(Object o) {
    // The fix is to not use toString()
    return ":" + o;
  }

}