Because it's used in CreateRoutineScreen, RoutinesScreen and ExercisesScreen, share the code.

me and fossdd see your github account for splitfit here. but we also see an account at codeberg -> is it out of date ? that would be sad.

Currently, single-character values are not selected on tap as a workaround for a bug where you cant replace them with the same value.

Check for open source software:

• build.gradle dependencies
  https://github.com/noahjutz/GymRoutines/blob/b0823422465240fb5d3b0de328249d81c15a8321/build.gradle#L11-L16
  https://github.com/noahjutz/GymRoutines/blob/b0823422465240fb5d3b0de328249d81c15a8321/app/build.gradle#L1-L6
  https://github.com/noahjutz/GymRoutines/blob/b0823422465240fb5d3b0de328249d81c15a8321/app/build.gradle#L46-L86
• drawables

Clean up the current code in CreateRoutineScreen by creating a Table composable.

https://doc.insert-koin.io/#/koin-android/viewmodel?id=viewmodel-and-injection-parameters

Instead of constructing an object like this:

SomeViewModel(id, get(Repository::class.java))

use koin's built in injection parameters.

val appModule = module {
    viewModel { (id : String) -> SomeViewModel(id, get(), get()) }
}

Instead of using a coroutine scope within Repository, make ViewModels / UI do that by using viewModelScope or rememberCoroutineScope().

I suggest adding a message box asks to confirm set deletion. Currently, the app doesn't ask the user to confirm the deletion process.

Whether @Composable fun onDispose or ViewModel.onCleared is used, the callback is not made when the entire app is stopped. Maybe use SavedStateHandle?

When creating a new exercise/routine and leaving without any modifications, don't save that exercise/routine.

Applies to:

• RoutinesScreen
• ExercisesScreen
• (PickExerciseScreen)
• CreateRoutineScreen

In order to increase stability and code quality, start migrating to full TDD.

The checked state of an exercise in PickExerciseScreen seems to be bound to position, not content. This becomes a problem when the user filters exercises by name (implemented: #43) and positions change accordingly.

I suggest adding a field for notes in the exercise's activity because in some cases it's vital to add a note explains important info about the exercise.

For example deps needs some explanation.

Currently, DataStore preferences are often handled withing compose UI components rather than their viewModels. In order to improve code quality, move this responsibility to ViewModels.

When focusing a TextField, the software keyboard doesn't always pop up. Reopening the app fixes the problem.

Reason: Unknown

Might be upstream

I suggest preventing duplicated exercises on commit command.

Current package names are:

• com.noahjutz.splitfit.fdroid for F-Droid build flavor
• com.noahjutz.splitfit.googleplay for Google Play build flavor
• com.noahjutz.splitfit is currently published on google play.

In order to avoid confusiong among users that use both stores, remove the suffix (.fdroid/.googleplay).

Removing .googleplay should be easy.

Removing .fdroid might require some changes in fdroiddata because com.noahjutz.splitfit.fdroid is already published on F-Droid.

Replacing this will most likely be version name suffixes.

For localization, extract UI strings to string resources.

Now that CreateExerciseViewModel has been revamped, the previous workaround, disallowing users from unchecking a checkbox if all others are unchecked, is removed.

I suggest enabling muli-lines for exercise's title (I forced to modify sqlite database manually to be able to add multi-lines)

Instead of using an Int value, use Duration along with a TypeConverters to convert using inSeconds and back using Int.seconds.

let's translate on weblate - it's easier than on github

https://weblate.bubu1.eu/

https://discuss.circleci.com/t/sporadic-exception-compilation-with-kotlin-compile-daemon-was-not-successful-java-rmi-unmarshalexception-error-unmarshaling-return-header-nested-exception/30131

https://stackoverflow.com/questions/55939204/circleci-error-unmarshaling-return-header-nested-exception-is

instead of using onDispose to call a ViewModel function, override onCleared in the ViewModel itself

Use ViewModel SavedStateHandle, inject using koin

Add the following:

• CONTRIBUTING.md
• contributing info to README
• Code of conduct
• Issue templates
• pull request template

In dependencies.kt, use better naming to reflect what the dependencies actually are. Also, find a better way to structure the objects grouping together dependencies. Options include:

• Grouping by service (compose, room, etc.)
  • Include version in this group?
• Grouping by dependency type (implementation, kapt, testImplementation, etc.)

App requests the following permissions for no reason:

• read phone status and identity
• modify or delete the contents of your shared storage
• read the contents of your shared storage

Reason: Unknown

In order to have the same apk signature and allow users to seamlessly update using both github releases and f-droid, use reproducible builds. https://f-droid.org/en/docs/Reproducible_Builds/

Would close noahjutz/GymRoutines#32

Hi,

I'm working on filling this workout plan, but I couldn't figure out where Splitfit stores its files.

May you please tell me where can I find the config files to be able to share my workout plan?

PS. I've a ton of the suggestions, so I'll post them one by one. Furthermore, I'll post them depending on my personal experience because there are critical fixings/feature requests. I wish to find some time to response to them.
Unfortunately I haven't any knowledge in Kotlin, so PR is impossible to me.

This is because observers are only notified when the value is replaced, not when its properties change.

val m = MutableStateFlow(Routine("test initial"))
m.value.name = "test updated" // This line does not cause an update
m.value = m.value.copy(name = "test updated") // This line does.

I suggest adding a filter for exercises activity (it's very hard to choose an exercise during creating/modifying routines)

The default name of the backup is splitfit-backup.sqlite3
I suggest adding a timestamp for it (something like splitfit-backup-<yyyy-MM-dd_HH-mm-ss.SSSSSS>.sqlite3)

DateTimeFormatter
    .ofPattern("yyyy-MM-dd HH:mm:ss.SSSSSS")
    .withZone(ZoneOffset.UTC)
    .format(Instant.now())

The app currently uses ProcessPhoenix to restart after exporting/importing the database. Not only is this bad UX, it doesn't work on API 30+ currently.

Restarting the app is a workaround. Instead of reopening the database after closing it, the entire app is restarted. It was easier to implement, but it should be possible to do it the right way.

First, double check if closing the database is necessary.

There is an online training platform named splitfit. So I suggest to rename the project to something else.

This causes the listed exercises to be filtered, even though the search bar is hidden, when returning to ExercisesScreen.

Current implementation

Call

Formatting

Desired implementation

Call

var reps = set.reps.formatString()

Formatting

fun Double?.formatString(): String {
  // Handle null
  if (this == null) return ""
  // Handle x.0
  if (this == floor(this)) return this.toInt().toString()
  // Anything else
  return this.toString()
}

Cards such as SetGroupCard rows, Routine and Exercise items in RoutinesScreen/ExercisesScreen are initially elevated, which looks weird when scrolling through a LazyColumn or opening a new screen.

I suggest adding a new field for adding image(animated & static)/video explains the exercise just like most other apps.
https://www.tutorialspoint.com/how-to-display-animated-gif-images-in-android-using-kotlin

In many cases the user needs to use more than one program (a group of routines), so I suggest adding programs in Splitfit.

For example:
I use Buff Dudes 12 Week Home Program & 12 Cardio Program workouts. The resultant list as you can see below impractical & lame

Currently, there is no compose implementation of ItemTouchHelper, but it will probably be introduced in the coming updates.

StackOverflow thread

Koin seems to be more lightweight and suitable for smaller projects, as opposed to Kodein. https://insert-koin.io

Make up button cancel and add a fab to confirm