Expand function fails on weird GET query params about nock HOT 4 OPEN

This seems to be my problem as well.

Starting from release 13.3.5 (getting rid of lodash) my integration tests started failing.
After some debugging it seems the culprit is the expand function which started to behave differently than before for URLs containing querystring params that are named like object properties e.g. https://www.example.com?q=foo&q.something=bar.

The following code works fine on 13.3.4, but fails on 13.3.5:

const nock = require('nock');
const fetch = require('node-fetch');

nock('https://www.example.com').get('/').query({ q: 'foo', 'q.something': 'bar' }).reply(200, 'hey');

fetch('https://www.example.com?q=foo&q.something=bar')
    .then((res) => res.text())
    .then((text) => console.log(text, 'text'));

It's the same story with parameters like q.something and q[something] - both used to work just fine until the 13.3.5 release.

from nock.

The fix as a patch for pnpm:

diff --git a/lib/common.js b/lib/common.js
index 97d7c30e4602157b2bf1d475afa6b79525fda606..82ed39892109e51375acf86fa18ca8028796d78d 100644
--- a/lib/common.js
+++ b/lib/common.js
@@ -499,7 +499,7 @@ function isStream(obj) {
 function normalizeClientRequestArgs(input, options, cb) {
   if (typeof input === 'string') {
     input = urlToOptions(new url.URL(input))
-  } else if (input instanceof url.URL) {
+  } else if (input instanceof url.URL || input.constructor.name === 'URL') {
     input = urlToOptions(input)
   } else {
     cb = options
@@ -731,7 +731,7 @@ const expand = input => {
             resultPtr[part] = {}
           }
         }
-        resultPtr = resultPtr[part]
+        resultPtr = { __nock_value: resultPtr[part] }
       }
     }
   }

The first part is a fix for something else (Clickhouse Node JS library doesn't work with nock without this fix as it's uses URLImpl class for URLs. Checking constructor name worked better in this case).

The second part is fix to always make sure the value is an object.

from nock.

Thanks @bartoszhernas!
Would you mind creating a pull request and adding a test?

from nock.

Two bug fixes with two corresponding tests added to PR.

I realised while writing test, that my original fix was really bad and was hiding the issue and braking URL comparison 🥶

from nock.