Giter VIP home page Giter VIP logo

Comments (3)

gr2m avatar gr2m commented on July 29, 2024

NB: the all open bugs link (https://github.com/nock/nock.js/issues?q=is%3Aissue+is%3Aopen+label%3Abug) in your issue template leads to a 404 - because it is pointing to an old repo name nock.js

thanks, fixed 👍

from nock.

mikicho avatar mikicho commented on July 29, 2024

@gr2m

This is because we ignore the interceptor's headers:

nock/lib/interceptor.js

Lines 68 to 74 in f4d1b15

this.reqheaders = common.headersFieldNamesToLowerCase(
scope.scopeOptions.reqheaders || {},
true,
)
this.badheaders = common.headersFieldsArrayToLowerCase(
scope.scopeOptions.badheaders || [],
)

What's the expected behavior? Should we merge the headers? Do the interceptor's headers take precedence? vice-versa?

P.S: @josephearl I think it worked on null because it failed to match the body.

from nock.

gr2m avatar gr2m commented on July 29, 2024

I don't know out of hand, I'd have to digg into it as well. I'd look at tests first to see if the behavior might be covered

from nock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.