Support:

http://v.ht/gtyt

Some branded shorteners (flic.kr, ali.pub) do multiple redirects via several domains. Now we have to list all such domains or write custom code. It would be nice to have option:

• follow all next redirects
• do not count next redirects

Important: with branded shorneters we can be sure that link will be landed predictably (not forwarded to another shortener).

suggestion

{ follow: true } or { deep: true }

• Add option.request as in embedza and probe-image-size

Hi,

Is possible to add a CDN version of the package? Utilities like https://www.jsdelivr.com/ are free for open source and CDN is a easy way to test the library in sites like JSFiddle,

Thanks

• callbacks -> promises (internal api)
• request -> got
  • restrict max body size by default

This doesn't look too good!

e.g. https://youtu.be/SzH4vNli5-M

Hi,

Just a small note on tinyUrl shortening service (https://github.com/nodeca/url-unshort/blob/master/domains.yml).

When shorten an URL with tinyUrl the process is:

1. Shorten the URL with tinyUrl.com
2. Access the shorten URL from step 1 will open the page preview.tinyUrl.com
3. Is a redirection but to an intermediary page that says:

This TinyURL redirects to:
URL from step 1
Proceed to this site.

Conclusion:

url-unshort will receive the redirection code and interpret it as the full unshorten URL. So, in the end, for tinyUrl, url-unshorten will return preview.tinyURL and not the correct one.

• Drop mdurl.
• Revisit returned errors.
  • What is criteria of cache store.
• Consider support select in .add().
  • Drop src attr check.
  • Document select rule (it's for <a> elements only).
• Consider support text_select.
• Should we add www. variant or leave that to aliases? Currently exists, but seems useless.
• Implement skipped test.

Not sure:

• Add famous partner program redirectors for aliexpress/ebay...
• Cleanup Google Analytics query params (probably should be done before/after unshort independently).

When used on something that is not a shortened url, it will hang forever:

require('url-unshort')().expand('https://google.com/').then(console.log)

Promise { <pending> }

The promise will never resolve. IMO this is risky behavior and causes memory leaks on our server. I would expect it to for example throw an error

Some shorteners can do several redirects and use cookies to pass data between. In theory we could process received cookies.

Notes:

1. Only vk.com use this method, but it can be processed without url request
2. Existing shorteners can behave different with cookies (should be tested)

suggestion

{ cookies: true}

When running the example I get this deprecation message

(node:56484) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
(Use `node --trace-deprecation ...` to show where the warning was created)
Original url is: https://github.com/nodeca/url-unshort

Is it possible to fix this?

My versions:

node --version                                                        
v16.9.0

npm --version   
7.21.1

grep url-unshort package.json 
    "url-unshort": "^5.0.0",