Comments (9)
We had some good discussion and talked about what we might be able to do that would be useful.
The only thing we have in mind so far might be to add a #define that can be used to exclude napi_create_external_buffer
so that it is easier for package authors to know if there are going to be problems on runtimes that no longer suppoirt it.
We'll think more about it and discuss again next week.
I don't think we have any hope of change electron's mind in terms of the decision they took.
from abi-stable-node.
Yeah, I think that a define would be a good help here. That will at least help those who are aware enough to enable it.
Hopefully a discussion can be had over whether node-addon-api
should enable that define by default in a future release.
I don't think we have any hope of change electron's mind in terms of the decision they took.
Yeah, now that it is in a stable release I dont expect they would.
But hopefully a discussion can be started with them to coordinate changes in the future. As I said in an issue with them, my biggest problem is the lack of notice and documentation. While they did do a blog post which was published a couple of months before, and it was mentioned in the release notes, I expect very few users/maintainers to see those. Any documentation about this api has no mention of this limitation
from abi-stable-node.
@Julusian I do agree it would have been nice for some co-ordination with the Node-API team to have been done up front. The more implementers we have the more important that becomes. Where there specific people that you talked to on the electron side who might be good people to reach out to?
from abi-stable-node.
All the discussion I have had with the elcecton team has been in an issue electron/electron#35801
from abi-stable-node.
@Julusian thanks for the pointer to the issue/discussion.
from abi-stable-node.
This comment from electron/electron#35801
I think I'd still prefer a stable API to detect the cage up-front rather than having the process crash. Failing that, we can add something explicit to the sharp API that allows someone developing for Electron 21+ to opt-in to copying the Buffer (and therefore opt-in to the performance and memory fragmentation cost).
Is worth discussing in the next Node-api team meeting.
from abi-stable-node.
Created this PR to do what we discussed in the last node-api team meeting - nodejs/node#45181
from abi-stable-node.
We discussed this in the 11 Nov Node API meeting.
Since nodejs/node#45181 has been merged, there is no additional work for the Node API team regarding this issue. We can close this issue @mhdawson .
from abi-stable-node.
@KevinEady at this point we just need the PRs to be backported to earlier release lines, but I'm ok with closing.
from abi-stable-node.
Related Issues (20)
- Ask for review of node-serialport Node-API port - https://github.com/serialport/node-serialport/pull/2305/files HOT 2
- Drive towards full coverage HOT 5
- Discuss Node-API addition https://github.com/nodejs/node/pull/41329#issuecomment-1015667899 HOT 1
- Regular hang in Running test 'typed_threadsafe_function/typed_threadsafe_function_sum' HOT 1
- Node-API v9 HOT 7
- Better coverage of node-api in Youtube HOT 13
- Node-API add-on build HOT 4
- Add list of non C language bindings to Node.js doc HOT 10
- Document how to check for memory leaks in addon/default leak. HOT 4
- Get contacts for each of the runtimes supporting Node-API HOT 8
- What's new in the Node-API and node-addon-api world? - 2023 version HOT 20
- Can references be shared between different modules/envs? HOT 3
- Improve score on OpenSSF scorecard HOT 8
- Consider changing the license for examples to MIT HOT 2
- Tracking issues for V8 changes needed HOT 1
- Help with node-sqlite3 performance HOT 3
- What's new in the Node-API and node-addon-api world? - 2024 version HOT 3
- Discuss reverting nogc commits HOT 1
- Warn/print message when NAPI_EXPERIMENTAL is used in a build HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abi-stable-node.