Common questions at C&L events about code-and-learn HOT 7 OPEN

Those issues are not code-and-learn specific, I think that they should be either resolved or mentioned in the documentation (e.g. BUILDING.md).

from code-and-learn.

Not necessarily 100% relevant but one comment I got was that its not always obvious who the mentors are. Something like wearing the same shirt or hats that stand out might help ?

So the question would be "who are the mentors"

from code-and-learn.

1. I completed my first PR, where do I go next? How do I get the list of next level PRs that I can make?

Please review https://www.nodetodo.org/next-steps/

2. Did you make this (the code change requirement) on purpose, for the new comers?

No, these are incremental improvements that we identified but kept on stock for this exercise. We did not artifically created these issues for the purpose of code & learn.

3. What happens if I raise PR on the master of my fork?

If you are raising a single PR no problem with that. When a second undertaking is being worked, the existing branch carries the first PR's content that is not desirable. So the best practise is to create one branch per PR and work inside that, for isolation and easy management.

4. How to run single test?

Exaplained above.

5. How do I know whether lint (or everything) passes? my output was too long, and at the end of it did not say success or failure.

If there is an error on any of the passes, the bottom of the log will clearly say so. If no error report found, that means all is well.

6. I am new to git and github. Can you teach me that first?

Sure, will plan for that next time.

from code-and-learn.

1. [macOS] test-cluster-bind-privileged-port and test-cluster-shared-handle-bind-privileged-port fail on macOS Mojave, see nodejs/node#21679.
   Solution: known Mojave issue, just ignore those two.
2. [macOS] Tests that launch subprocesses and wait for them to abort (e.g. test-process-abort-exitcode and test-domain-with-abort-on-uncaught-exception) take long to run and/or timeout on macOS with CrashReporter enabled.
   Solution: disable CrashReporter, see nodejs/node#13527 (comment).
3. Quite often, people have (slightly?) outdated master branch versions. git pull upstream master =).
4. [Windows]: There was a windows-specific problem with installing a proper Visual Studio build tools. Installing just "Visual C++ build tools" (as https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1 recommenda) didn't help. Installing some more Visual Studio-related stuff helped, but I don't have the details — I wasn't the one who resolved that.

from code-and-learn.

It would be useful if the tasks being assigned include the issue number of the associated issue so that committers can include a reference in their commit message.

from code-and-learn.

@mcqj Icreated these tasks specifically for the code and learn event and there are no issues for them. It would have been even more work to create issues and I hope you all had a good experience also without such a reference!

from code-and-learn.

No problem at all @BridgeAR

from code-and-learn.