Giter VIP home page Giter VIP logo

Comments (7)

targos avatar targos commented on August 15, 2024 6

I would also ask the organizers to avoid giving tasks that are purely style changes and/or that can be done automatically with eslint --fix.
I'm thinking especially about the tasks that change regular functions to arrow functions. IMO those changes do not improve the code base, make the git history harder to browse and sometimes remove useful information (For example: nodejs/node#24606 where we lose the names - ). We are also teaching something wrong to the developers: arrow functions are not the only correct way to write callbacks and were not created as a replacement for regular functions.

from code-and-learn.

trivikr avatar trivikr commented on August 15, 2024 1

cc @nodejs/chakracore as they're likely to be from Seattle area

from code-and-learn.

Trott avatar Trott commented on August 15, 2024 1

In the interest of continuous improvement of Code + Learn events, I'd ask that at this and future events, we make sure to encourage participants to:

  • Create meaningful PR descriptions and titles.
  • Read and comply with the GitHub PR template.
  • Refrain from putting together multiple unrelated changes in different files into a single PR.
  • Refrain from doing more than one task handed out at the event. Second tasks should involve finding something more interesting and meaningful (such as improving test coverage) than being asked to change a function to use arrow syntax. There is a list of suggestions at https://www.nodetodo.org/next-steps/. Additions and improvements to that list are more than welcome.

from code-and-learn.

trivikr avatar trivikr commented on August 15, 2024

CCing members of @nodejs/chakracore individually
@agarwal-sandeep @aruneshchandra @boingoing @curtisman @digitalinfinity @EdMaurer @ianwjhalliday @kfarnung @kunalspathak @obastemur @sethgaurav

from code-and-learn.

digitalinfinity avatar digitalinfinity commented on August 15, 2024

Aaaah @trivikr this is awesome and I'd have loved to have helped out but I'm out of town during this time 😢 - if you organize this again next year, please let me know and I'll try to help!
Other @nodejs/node-chakracore folks, if you have availability, I encourage y'all to go, it's a great way to help people who are eager to learn about Node. Also cc @MichelLopez @yodurr since they'll be interested.

from code-and-learn.

lpinca avatar lpinca commented on August 15, 2024

I totally agree with @targos

from code-and-learn.

trivikr avatar trivikr commented on August 15, 2024

Resolving this issue, as the event is postponed because proximity to the holiday season and lack of mentors.

We're planning to organize it either in late-Jan or early-Feb, and I'll create a new issue for it.

from code-and-learn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.