HTTP2 Requests hang upon receiving 'Stream closed with error code NGHTTP2_INTERNAL_ERROR' about undici HOT 6 OPEN

I can take care of this issue if it's appropriate

from undici.

Sure I can look at adding this patch + some test coverage, It'll likely be outside of my working hours so may be a week or so

from undici.

I opened a pr thank you very much for your support and explanations I hope I did it right if you have any suggestions please do not hesitate @metcoder95 @jackschu

from undici.

Yeah, that's a good catch and indeed a bug. Both belong to a single stream that is most likely tight to a single request/response lifecycle for fetch and undici itself.

There's no reason to reuse the same, it was most likely left over we forgot to check.

Would you like to send a PR? It might be hard, but let's see if we can add some tests.

from undici.

I took a swing at this but am running into some trouble around ClientDestroyedError

Currently something like this would result in the promise hanging, I don't think that's correct, and should instead result in a reject

  client.on('connect', () => {
    client.close()
  })
  await client.request({
    path: '/',
    method: 'GET',
  })

but just calling errorRequest on error in client.js's stream error handler results in a ClientDestroyedError seemingly if the client is closed without the body having been consumed eg the following will throw

  await client.request({
    path: '/',
    method: 'GET',
  })
  await client.close()

Any advice around how to handle this?

from undici.

Can you provide the full
Minimum Reproducible Example?

Feel free to also open a PR and we can iterate from it

from undici.