Comments (4)
Especially as it feels pretty unique to multipart/form-data (at least for now).
It is unique to multipart/form-data, as without the boundary type provided in the content-type header, it can't be parsed.
https://datatracker.ietf.org/doc/html/rfc7578
"boundary" is now a required parameter in
Content-Type.
I would keep supporting it in request() and override it in fetch().
Here's where we'd implement the logic. I wonder if we should take a look at reimplementing a subset of forbidden headers as we've had nothing but issues (host
header) and security vulnerabilities (cookie
, authorization
, proxy-authorization
) by not implementing them. Originally I wanted to follow Deno's behavior, but I'm second guessing my judgement... I know ronag's disapproved removing them too, way back when.
from undici.
Agree with the statement that these scenarios should be handled by the users rather than undici
or fetch
doing its best guest to cover that up.
However, I'm a little over the fence if this is something that should be changed within undici
or maybe a documentation improvement to be done. Especially as it feels pretty unique to multipart/form-data
(at least for now).
Should we consider adding a documentation improvement and a possible warning before considering it to throw
?
As said earlier, the only thing that it worries me is that this is becomes pretty specific to multipart/form-data
only
from undici.
I would keep supporting it in request()
and override it in fetch()
.
from undici.
IMHO those are needed for compat with the rest of the Node.js ecosystem.
SGTM on the implementation of in request.
from undici.
Related Issues (20)
- Retry Handler Fails When Request Has a Body HOT 5
- autobahn workflow is always 1 commit behind HOT 1
- Nightly tests are failing HOT 3
- (regression?) timeouts while reading a body no longer abort with a TimeoutError HOT 2
- Body timeout not working HOT 5
- Retrieve the URL when errored HOT 1
- SocketError: other side closed (with repro example) HOT 1
- Fetch failed with UND_ERR_CONNECT_TIMEOUT undici error on Next.js serverless function HOT 1
- 'interceptors' export doesn't work like in the docs HOT 1
- Nightly tests are failing HOT 4
- publish autobahn test results on the docs site HOT 7
- Nightly tests are failing HOT 2
- Improve support for pre-shared sessions (PSK) HOT 3
- Request constructor: Failed to parse URL from ___ HOT 2
- Broken links in docs webpage HOT 2
- Failing JSON parsing in Node 22 HOT 13
- undici/types/index.d.ts:21:8: Type error TS1192: Module '"[email protected]/node_modules/undici/types/interceptors"' has no default export HOT 6
- Node 22.3.0 regression: undici sends invalid origin header in some cases HOT 2
- fetch arrayBuffer() leaks random data from process memory HOT 7
- build: husky install is deprecated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from undici.