Giter VIP home page Giter VIP logo

Comments (3)

mcollina avatar mcollina commented on July 17, 2024 3

Is there a reason we spread these options first instead of last? I'd expect the module should prioritize the passed settings over anything internal by default in most cases.

as you can see, in that example, we are reading the session from the cache. I guess this was added without thinking of the preshared key.

A PR that improves this would be great.

from undici.

tastypackets avatar tastypackets commented on July 17, 2024

I don't mind opening a PR for this, but think it first needs some discussion/review to make sure we are aligned on the path forward.

Also side note I noticed the type for factory options is object, which made this a bit confusing at first when I thought I could simply inject my session on the pool factory only to discover the connect type is actually a function. It'd be great to improve that type.

from undici.

tastypackets avatar tastypackets commented on July 17, 2024

@mcollina opened a draft PR to simply spread options at the bottom, so anything can be overriden. Do you think this is okay or was it intentional somethings like socket and ALPNProtocols are set by the module?

from undici.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.