nomacs / nomacs Goto Github PK

nomacs/snapshot/src/DkCore/DkUtils.cpp:67:9: error: expected primary-expression before ‘while’

it would be nice if the libraries would be installed outside the search path of shared libraries - if they are not shared. In case they should be shared, please give them a soname

Arch + i3wm

if I use xdg-open zzz.png, it gets opened in nomacs, then after closing, image is open again in another available application for viewing images.

I am not sure if this is nomacs issue, or my system issue, or xdg-open issue
but if I change the default application in mimeapps.list to gpicview or firefox then its fine

opening picture with nomacs zzz.png would work just fine, only when coupled with xdg it starts to have issues

Is there some non obvious functionality of nomacs that could be responsible for this?
I tried reseting to default settings and deleting the nomacs folder in ~/.config

when I tried at first removing the secondary opened applications from my system(mupdf, gpicview), it started to on close open nomacs again, and then after secondary close open firefox new tab with the picture

if nothing comes to mind then it might be just my screwed up system

Is this possible? I can't seem to find a setting for it in nomacs or settings.nfo

Win7 x64
3.2 portable

Hello
Thanks for the grate app, all grate but I could not make it remember the visibility settings for toolbar, I searched to see whether it possible in the first place http://nomacs.org/questions-and-answers/:

" thomas" would like to see it remember the screen layout (toolbar/palette visibility)...
"markus" nomacs does remember toolbar visibility/position and other elements...

It appears that it's possible , I searched for an option in settings.nfo but I didn't find one, other settings like zoomToFit is working perfectly .

Hi there

Is it possible to use my native icons, which are used for every other Qt programm on my system?

If not, are you interested in help with adding in support ?

Right now i can only assume that it is GPL, but ...

src/DkLoader/DkUpnp.h: No copyright UNKNOWN
src/DkLoader/DkUpnp.cpp: No copyright UNKNOWN

lena.jpg and lena-full.jpg are non-free.
Attachment is CC-BY.

This would be a really awesome feature!

if user open an image by double clicking it from a file browser, a tab should be added to an existing instance rather than opening a new instance.

It would be nice if nomacs would start in the thumbnail preview when passed a directory as an argument on the command line. Saves having to press Shift+T every time on startup.

If you dont want that to be the default gehavior, then an option to turn it on would work, either as a command line switch or a preference in settings.

I thought that frameless mode was a great idea to toggle between “just show me the image” and “wow, I can do everything!” modes. That was until I realized that frameless mode does not work so well with tiling window managers (also see http://nomacs.org/redmine/issues/495).

I'd like to have a button that will turn off all panels/toolbars and then turn them all back when I press it again. Perhaps one way to implement this is to add support for “workspaces” or something like that (different configurations and easy way to toggle between them).

Just noticed this as it broke the Release Notes URL on Chocolatey.org. They were going on the assumption that MAJOR.Minor.patch was the standard (based on prior releases) and so they created their links with those positions, but the 3.4 tag appears to have dropped the .0 that was present in other releases. Not a huge deal, just wanted to make you aware this could break other things elsewhere.

nomacs browses inside zip files, even when the option is turned off
registring a file type, from the settings menu, also doesn't seem to work under KDE 5.12

Why nomacs doesn't appear on the "default programs" in Windows 10? It makes it much harder to assign file types.

nomacs 3.2.0 crashes on delete, win 8.1 x64

like in bb45d92 - it would make a nice version number for debian instead a version with git hash and so on. Thanks :P

Dear @diemmarkus
I was trying to build Nomacs after I had merged your new commits
I found these errors
error: ‘class QNoDebug’ has no member named ‘noquote’ in DkSettings.cpp:257:8
error: ‘QtInfoMsg’ was not declared in this scope in DkUtils.cpp:85:7

I think its related to commit 8a97692305b4e7cf627ef7ec1f402eca264f0884

I updated my qt version from 5.4 to 5.6 but the problem is still happens

Thanks

Trackpoints provide both vertical and horizontal scrolling. However, it is pretty hard to scroll vertically without accidentally moving your trackpoint horizontally.

In nomacs horizontal scrolling switches between pictures in the folder. This means that whenever I try to zoom in I accidentally change the picture (well, unless I'm very accurate). This is very annoying.

Please add an option to disable this functionality for horizontal scrolling.

Hi all ,

i am trying to build nomacs for master branch but i found this , what should i do ?

Thanks

[ 1%] Building CXX object CMakeFiles/nomacs.dir/src/DkViewPort.cpp.o
In file included from /usr/include/exiv2/metadatum.hpp:39:0,
from /usr/include/exiv2/exif.hpp:34,
from /usr/include/exiv2/bmpimage.hpp:34,
from /usr/include/exiv2/exiv2.hpp:35,
from /home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkMetaData.h:49,
from /home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkBasicLoader.h:37,
from /home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkImage.h:104,
from /home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.h:69,
from /home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.cpp:28:
/usr/include/exiv2/value.hpp:984:25: note: attribute for ‘struct Exiv2::DateValue::Date’ must follow the ‘struct’ keyword
EXIV2API struct Date
^
/home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.cpp: In member function ‘virtual void nmc::DkViewPortContrast::setImage(QImage)’:
/home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.cpp:2776:4: error: ‘vector’ was not declared in this scope
vector planes;
^
/home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.cpp:2776:4: note: suggested alternative:
In file included from /usr/include/c++/4.8/vector:64:0,
from /usr/include/qt5/QtCore/qmetatype.h:56,
from /usr/include/qt5/QtCore/qobject.h:56,
from /usr/include/qt5/QtWidgets/qwidget.h:46,
from /usr/include/qt5/QtWidgets/qdesktopwidget.h:45,
from /usr/include/qt5/QtWidgets/QDesktopWidget:1,
from /home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.h:31,
from /home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.cpp:28:
/usr/include/c++/4.8/bits/stl_vector.h:210:11: note: ‘std::vector’
class vector : protected _Vector_base<_Tp, _Alloc>
^
/home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.cpp:2776:14: error: expected primary-expression before ‘>’ token
vector planes;
^
/home/aly/projects/gsoc_projects/nomacs/ImageLounge/src/DkViewPort.cpp:2776:16: error: ‘planes’ was not declared in this scope
vector planes;
^
make[2]: *** [CMakeFiles/nomacs.dir/src/DkViewPort.cpp.o] Error 1
make[1]: *** [CMakeFiles/nomacs.dir/all] Error 2
make: *** [all] Error 2

I do
cd nomacs/ImageLounge
cmake . -DCMAKE_INSTALL_PREFIX=/usr -DENABLE_QT5=ON -DENABLE_QUAZIP=OFF -DQT_QMAKE_EXECUTABLE=/usr/bin/qmake-qt5
then make
and get the following error message:

irtual void nmc::DkThumbsView::mouseMoveEvent(QMouseEvent_)»:
/home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.cpp:1398:33: error: invalid use of incomplete type «class QDrag»
QDrag_ drag = new QDrag(this);
^
In file included from /usr/include/qt/QtWidgets/qtreeview.h:37:0,
from /usr/include/qt/QtWidgets/QTreeView:1,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkWidgets.h:55,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.h:32,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.cpp:28:
/usr/include/qt/QtWidgets/qabstractitemview.h:48:7: error: forward declaration of «class QDrag»
class QDrag;
^
/home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.cpp:1399:9: error: invalid use of incomplete type «class QDrag»
drag->setMimeData(mimeData);
^
In file included from /usr/include/qt/QtWidgets/qtreeview.h:37:0,
from /usr/include/qt/QtWidgets/QTreeView:1,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkWidgets.h:55,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.h:32,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.cpp:28:
/usr/include/qt/QtWidgets/qabstractitemview.h:48:7: ошибка: forward declaration of «class QDrag»
class QDrag;
^
/home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.cpp:1400:37: error: invalid use of incomplete type «class QDrag»
Qt::DropAction dropAction = drag->exec(Qt::CopyAction);
^
In file included from /usr/include/qt/QtWidgets/qtreeview.h:37:0,
from /usr/include/qt/QtWidgets/QTreeView:1,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkWidgets.h:55,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.h:32,
from /home/ilya/build/lxqt/nomacs/src/nomacs/ImageLounge/src/DkThumbsWidgets.cpp:28:
/usr/include/qt/QtWidgets/qabstractitemview.h:48:7: error: forward declaration of «class QDrag»
class QDrag;

Since some wheeks compiling nomacs on Arch Linux the same way as before is failing.

Unfortunately the make output isn't exactly telling to me so please just find it at https://gist.github.com/pmattern/0613ce8ab445135c2a3191c6385edf96.

Can you please include COPYING, PATENTS, AUTHORS into 3rdparty/libwebp - without the file headers would make no sense:

// Use of this source code is governed by a BSD-style license
// that can be found in the COPYING file in the root of the source
// tree. An additional intellectual property rights grant can be found
// in the file PATENTS. All contributing project authors may
// be found in the AUTHORS file in the root of the source tree.

/builddir/build/BUILD/nomacs-3.2.0/src/DkGui/DkViewPort.cpp:1254:89: error: call of overloaded 'abs(double&)' is ambiguous
double speed = mAnimationValue > 0.5 ? abs(1.0 - mAnimationValue) : abs(mAnimationValue);

nomacs-ambiguous_call_to_abs.patch.txt

load save states from profile

Would it be possible to add WebP support to nomacs?

https://en.wikipedia.org/wiki/WebP

Is it possible that nomacs read SVG files? On Linux OS, it's not that hard to read them, there's some others images viewers, but on Windows, there's not much, and really, it would be good. I don't know if it's hard or not to do, I just ask to know if you want/plan it.

If a file is changed on disk, I have to press F5 to update it.

It would be useful if there was an option to refresh images automatically.

The method to clear keyboard shortcuts is confusing.

1. Open Keyboard Shortcuts dialog
2. Interact with the dialog

Expected result: Some indication on how to remove a keyboard shortcut
Actual result: No indication on how to remove a keyboard shortcut

After a lot of trial and error, I did find a method that kind of works.

1. Find the key combination for a shortcut you want to remove
2. Double-click another shortcut
3. Enter the shortcut key combination of the entry you want to remove
4. Click out of the shortcut input
5. Click OK

However, the dialog must be closed and then re-opened for each binding you replace.

Hi,

When "registering" a file type in Edit > Settings > File Filters, I would expect it to change the default application for the current user. In Linux, this is typically done by modifying $HOME/.local/share/applications/mimeapps.list which is used by xdg-open. I can't however see a change, and the default image viewer is unaffected. But perhaps I'm missing something obvious?

nomacs 2.2.0-1
Arch Linux x64

The 44 line of DkMetaData.cpp contains #include "C:\Qt\qt-everywhere-opensource-src-4.8.5-x86-native-gestures\src\3rdparty\libpng\png.h" that obviously crashes linux build.

After changing it to #include <png.h> the build can go forward, but another error appears:

ImageLounge/src/DkBatch.cpp:181:28: error: invalid use of incomplete type «const class QMimeData» if (!mimeData || !mimeData->hasUrls()) ^ In file included from /usr/include/qt/QtWidgets/QTextEdit:1:0, from /ImageLounge/src/DkBatch.h:34, from /ImageLounge/src/DkBatch.cpp:28: /usr/include/qt/QtWidgets/qtextedit.h:53:7: error: forward declaration of «const class QMimeData» class QMimeData; ^ /ImageLounge/src/DkBatch.cpp:186:26: error: invalid use of incomplete type «const class QMimeData» for (QUrl url : mimeData->urls()) { ^ In file included from /usr/include/qt/QtWidgets/QTextEdit:1:0, from /ImageLounge/src/DkBatch.h:34, from /ImageLounge/src/DkBatch.cpp:28: /usr/include/qt/QtWidgets/qtextedit.h:53:7: error: forward declaration of «const class QMimeData» class QMimeData; ^ /ImageLounge/src/DkBatch.cpp: В функции-члене «virtual void nmc::DkInputTextEdit::dragEnterEvent(QDragEnterEvent*)»: /ImageLounge/src/DkBatch.cpp:215:28: error: invalid use of incomplete type «const class QMimeData» else if (event->mimeData()->hasUrls()) ^ In file included from /usr/include/qt/QtWidgets/QTextEdit:1:0, from /ImageLounge/src/DkBatch.h:34, from /ImageLounge/src/DkBatch.cpp:28: /usr/include/qt/QtWidgets/qtextedit.h:53:7: error: forward declaration of «const class QMimeData» class QMimeData; ^ /ImageLounge/src/DkBatch.cpp: В функции-члене «virtual void nmc::DkInputTextEdit::dragMoveEvent(QDragMoveEvent*)»: /ImageLounge/src/DkBatch.cpp:225:28: error: invalid use of incomplete type «const class QMimeData» else if (event->mimeData()->hasUrls()) ^ In file included from /usr/include/qt/QtWidgets/QTextEdit:1:0, from /ImageLounge/src/DkBatch.h:34, from /ImageLounge/src/DkBatch.cpp:28: /usr/include/qt/QtWidgets/qtextedit.h:53:7: error: forward declaration of «const class QMimeData» class QMimeData; ^

When i open multiple images, the taskbar icon is only visible in the instance that was launched first.
I use the latest KDE on Arch Linux and Nomacs 3.0.

This commit, line 1070:
55fc3f5#diff-79302691035a6cf316b751e790cdb679R1070
Introduced a deprecated in Qt5 fromAscii call
http://qt-project.org/wiki/Transition_from_Qt_4.x_to_Qt5

Build of 2.4.2 with Qt5 is fixed with:
sed -i 's|fromAscii|fromLatin1|g' $srcdir/$pkgname-$pkgver/src/DkMetaData.cpp

/usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libraw.so: Nicht definierter Verweis auf `GOMP_parallel@GOMP_4.0'

on Ubuntu 16.04.2 LTS

nomacs currently seems to have no high DPI support. Setting

QT_AUTO_SCREEN_SCALE_FACTOR=1

causes the UI to look correct, but images are pixelated. Without that environment variables, images look correct but the toolbar icons are too small.

Using

QApplication::setAttribute(Qt::AA_EnableHighDpiScaling, False)
QApplication::setAttribute(Qt::AA_UseHighDpiPixmaps)

And setting the toolbar icon size using pts rather than pixels should fix these issues (the typical approach is to make the toolbar 1.5 * lineheight where you get line haeing fromQFontMetrics of the application font.)

https://doc.qt.io/qt-5/highdpi.html

Please retag the release with an annotated tag - git describe would work better with it. Thanks.

Hi,
packaging nomacs for debian i get the lintian warnings:

E: nomacs source: license-problem-non-free-img-lenna src/img/lena-full.jpg
E: nomacs source: license-problem-non-free-img-lenna src/img/lena.jpg

Can you change this upstream please, rationale: https://www.preining.info/blog/2015/07/amusing-lintian-error-lenna/

DISCLAIMER: I'm old enough now and i'm not offended - but this image is non-free :D

Cheers Alf

Hi there - i like to change the position, opacity and size of the player: Can you implement it as new feature?
Otherwise: Can you link me the position of the source code, which manage that?

Thanks a lot in advance

DkImageLoader.cpp:515:120: error: ‘class nmc::DkImageContainerT’ has no member named ‘getZipData’
if (mCurrentImage && (newFileIdx < 0 || newFileIdx >= mImages.size()) && mCurrentImage->isFromZip() && mCurrentImage->getZipData()) {

• When navigating between tabs the zoom level is reset to default.
  It would be very useful if the zoom level of each tab is remembered while it's open.
• Option for Vertical tabs?
  After opening a couple of tabs it becomes very difficult to navigate.
  Vertical tabs would make navigation of several (or dozens) of images ridiculously easy.
  Scrolling through them with mousewheel and having middle-click to close would be ideal extra functionality.

I've been using nomacs for quite a while now and It's great to see it coming along so nicely. Thank you!

Win7 x64
3.2 portable

Hi

does nomacs support OpenCV 3?

I got this while building it on Slackware

CMake Error at cmake/Unix.cmake:46 (find_package):
  Could not find a configuration file for package "OpenCV" that is compatible
  with requested version "2.1.0".

  The following configuration files were considered but not accepted:

    /usr/share/opencv/OpenCVConfig.cmake, version: 3.1.0

Call Stack (most recent call first):
  CMakeLists.txt:81 (include)

clicking a tab with the mouse wheel could close tabs (similar to e.g. Firefox)

In recent VCS checkouts make install invoked after successfully running cmake . and make, all in ./nomacs/ImageLounge/, fails as it still looks for a file nomacs.png that was dropped a while ago:

[...]
CMake Error at cmake_install.cmake:76 (file):
  file INSTALL cannot find
  "/usr/local/peter/nomacs/ImageLounge/src/img/nomacs.png".
[...]

Bisecting suggests it's a regression introduced in e2ad387.

All tests on up to date Arch Linux x86_64.

On Linux recent VCS checkouts can be compiled successfully but fail to start throwing a warning error while loading shared libraries: libnomacsGui.so: cannot open shared object file: No such file or directory.

Problem can be seen as of 1a5a0c5, the predecessors failed to build for different reasons.
Regarding 87a6168 and aeadc94 make failed throwing

/usr/bin/ld: CMakeFiles/nomacs.dir/3rdparty/libwebp/src/utils/thread.c.o: undefined reference to symbol 'pthread_create@@GLIBC_2.2.5'
/usr/lib/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
CMakeFiles/nomacs.dir/build.make:1912: recipe for target 'nomacs' failed
make[2]: *** [nomacs] Error 1
CMakeFiles/Makefile2:102: recipe for target 'CMakeFiles/nomacs.dir/all' failed
make[1]: *** [CMakeFiles/nomacs.dir/all] Error 2
Makefile:149: recipe for target 'all' failed
make: *** [all] Error 2

while in becc101 it's already cmake to fail, corresponding error message is

CMake Error at cmake/UnixBuildTarget.cmake:86 (LIST):
  list sub-command REMOVE_ITEM requires list to be present.
Call Stack (most recent call first):
  CMakeLists.txt:149 (include)

All tests on up to date Arch Linux x86_64.

When configured with cmake -DENABLE_OPENCV=OFF -DENABLE_RAW=OFF -DENABLE_TIFF=OFF, build fails:

/home/michael/dev/nomacs/ImageLounge/src/DkLoader/DkBasicLoader.cpp: In member function ‘bool nmc::DkBasicLoader::loadGeneral(const QString&, QSharedPointer<QByteArray>, bool, bool)’:

/home/michael/dev/nomacs/ImageLounge/src/DkLoader/DkBasicLoader.cpp:280:47: error: no matching function for call to ‘nmc::DkBasicLoader::loadOpenCVVecFile(QString&, QImage&, QSharedPointer<QByteArray>&)’
   imgLoaded = loadOpenCVVecFile(mFile, img, ba);

Is it possible yo update source strings at crowdin so that we can work on the changes?

Hi, I've got in a mess for being adventurous.
Installing in ubuntu 15.10 following the instructions from the readme file:

1._ sudo apt-get install debhelper cdbs qt4-qmake libqt4-dev libexiv2-dev libraw-dev libopencv-dev cmake libtiff-dev git_ -Done-
2. git clone https://github.com/nomacs/nomacs.git -Done-
3._ Go to the nomacs/ImageLounge directory and run cmake to get the Makefiles
cmake . _-Done-

When running

cmake . -DCMAKE_INSTALL_PREFIX=/usr -DENABLE_QT5=ON -DENABLE_QUAZIP=OFF -DQT_QMAKE_EXECUTABLE=/usr/bin/qmake-qt5

Command output:

-- QMake found: path: /usr/bin/qmake-qt5
CMake Error at cmake/Utils.cmake:243 (find_package):
By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Qt5", but
CMake did not find one.

Could not find a package configuration file provided by "Qt5" with any of
the following names:

Qt5Config.cmake
qt5-config.cmake

Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
to a directory containing one of the above files. If "Qt5" provides a
separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
CMakeLists.txt:92 (NMC_FINDQT)

-- Configuring incomplete, errors occurred!
See also "/home/mcx/nomacs/ImageLounge/CMakeFiles/CMakeOutput.log".

Then I don't know what to do.

Lepton is a tool and file format for losslessly compressing JPEGs by an average of 22%
https://github.com/dropbox/lepton

Would it be possible to view images saved in this format via nomacs? I would really appreciate it.