normandmickey / skill-internet-radio Goto Github PK

Would it be possible to implement a volume request just for internet radio, separate from the system as a whole? Some stations are rather loud, and if you turn them down to a reasonable volume then Mycroft himself is too quiet.

Feature request

Would be great to be able to add additional stations for genres / categories unlisted

Thanks!

i forked this and made a new version

it reads a folder from settings, in that folder is checks for "name.value" files , inside those it expects name , url pairs in csv format, this makes it super easy to add new stations

please have a look, i would create a PR but theres some massive changes, let me know if you are interested!

https://github.com/JarbasAl/skill-internet-radio

i am using my AudioSkill class to handle some stuff, so the code may not seem obvious in some parts

02:21:10.683 - mycroft.skills.core:wrapper:663 - ERROR - An error occurred while processing a request in InternetRadioSkill
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/mycroft_core-0.9.14-py2.7.egg/mycroft/skills/core.py", line 639, in wrapper
handler(message)
File "/opt/mycroft/skills/skill-internet-radio/init.py", line 316, in handle_intent
self.audioservice.play(self.settings['station_url'])
File "/usr/local/lib/python2.7/site-packages/mycroft_core-0.9.14-py2.7.egg/mycroft/skills/settings.py", line 160, in getitem
return super(SkillSettings, self).getitem(key)
KeyError: 'station_url'

this is in a Mark1, specifying the station name works

internet radio -> an error occured
rock radio -> works

suggestion:

use self.settings.get("station_url", "default url")

it seems station_url is missing from websettings, putting the field there should auto populate this in the settings aswell

No audio can be heard after requesting a radio station, e.g. "play rock radio". I get the audio confirmation of "playing internet radio" and have checked that the stream URL works.

When attempting to update skills via mycroft-msm, I get the following error -

ERROR - Error running update_skill on skill-internet-radio.normandmickey: SkillModified(Uncommitted changes:
         M settings.json
)

Hi... this is working great for me, but it's a little weird to have to divide my favorite stations into "rock", "country", "Christmas", etc. Any possibility of just making it so I can say the station's name or some other arbitrary text to make it play?

Hi there @normandmickey , firstly we’d like to say a huge well done on the Internet Radio Skill

We’ve now moved mycroft-skills to the 18.08 branch, and we’d really love to have the Internet Radio Skill available on this branch. If your Skill was already accepted into the 18.02 branch, getting it on to the 18.08 branch is likely to be really simple and easy - simply a case of submitting it to the mycroft-skills repo again.

To make this easier, we now have the Mycroft Skills Kit - msk - available.

To open a PR on mycroft-skills, all your have to do is:

    cd <skill folder>
    mycroft-msk upload . 

First, activate the virtual environment.

kathyreid@kathyreid-Oryx-Pro:~/mycroft-core$ source venv-activate.sh 
Entering Mycroft virtual environment.  Run 'mycroft-venv-deactivate' to exit
Next, run msk upload with the path of where your Skill directory is locally. 
(.venv) kathyreid@kathyreid-Oryx-Pro:~/mycroft-core$ msk upload /path/to/where/your/skill/is/your-skill-name.username

For 18.08 we have a brand new Skill README editor, available at;
https://raw.githack.com/MycroftAI/mycroft-skills/18.08/meta_editor.html

If your Skill is a straightforward resubmission, and just a README change, then we won’t put it through the full Skill Acceptance Process - we’ll just do a quick check to make sure everything’s shiny.

More information:

• Skill branching
• What you need to know about the 18.08b branch
• Moving from Python 2.7 to Python 3.x

We're also very happy to help assist with your Skill - find us in the Skills Chatroom at Mycroft Chat.

Kind regards,
Kathy

Mycroft AI

From the error log:

10:50:31.655 - mycroft.skills.core:load_skill:169 - ERROR - Failed to load skill: skill-internet-radio.normandmickey
Traceback (most recent call last):
  File "/home/glor/git/mycroft-core/mycroft/skills/core.py", line 149, in load_skill
    raise e
  File "/home/glor/git/mycroft-core/mycroft/skills/core.py", line 145, in load_skill
    skill.initialize()
  File "/opt/mycroft/skills/skill-internet-radio.normandmickey/__init__.py", line 157, in initialize
    self.audioservice = AudioService(self.emitter)
AttributeError: 'InternetRadioSkill' object has no attribute 'emitter'

Mycroft currently says "Playing Internet radio" before the music starts, would be great if he were to say "Playing rock radio" or something similar.

Thanks!