nothings / stb-imv Goto Github PK

Read this document:
  http://code.google.com/p/stb-imv/wiki/FeatureRequests

First off: is there anyway for me to set the issue attributes (type,
status, etc)?

Transparent PNGs show up with a magenta background. If you use
CreateWindowEx, you can create a layered window that supports per-pixel
transparency, drawn with a DIBSection and UpdateLayeredWindow:

http://msdn2.microsoft.com/en-us/library/ms633556.aspx

Normally, uses UpdateLayeredWindow requires some changes to the window loop
because of the funny way it deals (or doesn't) with WM_PAINT, but the code
looks like it already does that. Also, since the resampler already
generates 32-bit color, all that is needed is some alpha premultiplication
code.

UpdateLayeredWindow might be able to be used to conveniently do some
effects for slideshows.

It's been a while since I've mucked in the code, but recent discussions at
work have made me nervous about how the stb-imv might be depending on
certain properties of "volatile" that are not guaranteed.

http://softwareblogs.intel.com/2007/11/30/volatile-almost-useless-for-multi-thre
aded-programming/

I'm guessing the current use of "volatile" is either incorrect or
unnecessary. Thoughts?

What steps will reproduce the problem?
1. create a folder with any name containing a space character
2. put imv_light.exe into that folder, add some image
3. launch imv_light.exe some.image.jpg
4. press CTRL+I

What is the expected output? What do you see instead?
New viewer window should open. Error message is displayed instead, called 
"imv(stb) error" stating "'Files\imv_light.exe': Couldn't open file".

What version of the product are you using? On what operating system?
stb_imv-1.01.zip Windows binary, version 1.01
on Windows 7 HP x64

What steps will reproduce the problem?
1. Open an image with imv
2. Press P to open preferences
3. Un-check "Show border" and press OK. The program crashes to the standard
windows crash dialog.

What version of the product are you using? On what operating system?
1.0 (w/GDI+)

Please provide any additional information below.
Border-toggling with keyboard shortcuts work fine. Only the toggling via
pref. dialog crashes.

(I don't actually care about disabling border, I'm just reporting the bug
because I happened to notice it.)

What steps will reproduce the problem?
1. Run stb-imv in folder with 100+ pics.
2. Browse near all of them.
3. Find in Task Manager 200-300Mb+ of consumed memory.

What is the expected output? What do you see instead?
I think you need free memory from already seen files.

What version of the product are you using? On what operating system?
Windows, imv-stb 1.01

Can the program be changed to step through images sorted by whatever
arrangement is chosen in the explorer window (date modified, etc.)?  Right
now it only steps by name arrangement.  Thanks for this great app!

What version of the product are you using? On what operating system?
Windows XP Pro SP2

1. Double click imv.exe and select an image or drop an image.
2. Press space key or backspace.
3. Crash.

I'm using stb_imv-0.96.zip on Windows XP SP2.

The "back" and "forward" buttons present on many mice and keyboards should
step through images in a folder, the same way they navigate through web
pages and explorer windows.

What version of the product are you using? On what operating system?
--0.97 Windows XP Pro SP2

Please provide any additional information below.

This is probably a better place than the forum to post this:

Currently, stb(imv) uses stb-img and FreeImage to decode images. stb-img
doesn't handle all file types, and FreeImage requires an additional DLL to
be distributed with the app. Additionally, FreeImage has issues with
certain file types, including crash bugs on BMPs generated by Adobe Photoshop.

GDI+ should solve both of these issues. GDI+ is already distributed with
most versions of Windows, so it doesn't need to be redistributed.
Secondarily, GDI+ is probably more stable than FreeImage, should handle
more file types/variations, and probably doesn't crash.

Some additional requirements for implementation are:
1) The build shouldn't require a new Platform SDK (i.e. should build with
any version fo Visual Studio 6 or better)
2) Should be implemented in C (rather than C++).

The GDI+ DLL is actually a pure C DLL that exports an unsupported "flat"
API, and the supported C++ interface is transparently implemented in header
files. These header files essentially behave as documentation for the flat
API. It should be a trivial matter to first implement the functionality in
C++, replace it with the equivalent flat C calls, and then dynamically link
the C entry points.

The relevant methods are: GdipCreateBitmapFromFile, GdipBitmapLockBits
GdipBitmapUnlockBits, GdipDisposeImage, GdipGdiplusShutdown, GdiplusStartup.

just based around stb_image?

Thanks.

I have this crazy custom image file format that is actually really simple
to implement it, and I'm looking to get it into some open source image
viewer... I doubt anybody else would ever use it, but it would make a huge
different for me to have it.

http://daeyna.com/spk/spk.txt

Let me know what you think.

I tried handling WM_SETFOCUS and WM_KILLFOCUS to toggle the stripe on the frame 
so as to make it all black when the window had focus. However I'm not too good 
at windows, nor do I really understand your code and I couldn't make it work.

Would be good to have if it could be done easily.

Stb-imv does not compile without modifying the source on the free MingW
toolchain. Luckily, the modifications needed are fairly minor.

in stb.h:
- disabled using the assembly version of stb_log_floor
- typedef unsigned __int64 stb__64; (instead of _int64)
- commented out the redefinition of CreateSemaphoreA
- removed the stb_barrier functionality. (This probably isn't safe, right?)
in stb_image.c:
- made the uint8, etc typedefs #defines instead.
- removed validate_uint32
- changed the last line to #endif (instead of #endif STBI_NO_WRITE)
in imv.c:
- removed the memory barrier (again, unsafe?)
- moved "int temp = max_cache_bytes >> 20;" out of the if() statement
- made rom_images not extern.
- disabled using the MMX assembly interpolation functions (#if 1 -> #if 0)

And compiled with gcc -o stbimv.exe imv.c -lgdi32 -luser32 -lcomdlg32
-lole32 -D_MT

Tested using Windows XP, gcc version 3.4.2 (mingw-special).

Hope this helps somehow! :)

If Windows taskbar option "Auto-hide the taskbar" is disabled, with default 
program window size part of big image appears under windows taskbar and can't 
be seen. 
Can you change default window size related on this option and decrease a little 
when "Auto-hide the taskbar" is disabled ?

TIA.

Load images in thumbs.db/thumbcache to act as quick placeholders for fast
browsing.

Useless link: http://en.wikipedia.org/wiki/Thumbs.db

What steps will reproduce the problem?
 1. Open an image with imv.exe
 2. Press F1

What is the expected output? What do you see instead?
 - Expected: as mentioned in readme.txt, I expected to see some documentation (features, keyboard shortcuts)
 - Instead: nothing happens

What version of the product are you using? On what operating system?
 - imv 1.01
 - Windows 7 x64 SP1 english, up-to-date

When alt tabbing, the window shows up as stb-imv or somesuch; it would be good 
to have the file name appended to this. Again I tried hacking the code and sort 
of got it going in the call to CreateWindow, but this doesn't help when 
browsing or using the slideshow.

Again, just a minor niggle with a great bit of kit.

Would it be possible (or is it already?) to start the viewer in fullscreen, so 
I don't have to press ALT+ENTER every time I launch it?
A Preference item/option/checkbox for that would be really great.
TIA.

I will quote/paraphrase the original GDI+ issue:

stb-img and GDI+ doesn't handle all file types, and FreeImage requires an 
additional DLL to be distributed with the app.
WIC should solve both of these issues. WIC is already distributed with newer 
versions of Windows (Vista+), so it doesn't need to be redistributed. 
Secondarily, WIC is probably more stable than GDI+, should handle more file 
types/variations, and will crash less.

There is e.g. http://www.fastpictureviewer.com/codecs/ codec pack which plugs 
into WIC that adds immense number of supported image and RAW formats, that 
could be used.
I guess all four major costs are significant for this one.

Some reference:
http://msdn.microsoft.com/en-us/library/windows/desktop/ee719886(v=vs.85).aspx
http://www.dustyfish.com/blog/reading-photo-metadata-using-windows-imaging-compo
nent
http://www.codeproject.com/Articles/25890/Windows-Imaging-Component

What steps will reproduce the problem?
1. Open a .tga file using the command line in a directory containing both .tga 
and other image types
2. cycle through the images in the directory

What is the expected output? What do you see instead?
The first tga displays just fine, so I would expect the rest of the tga's to be 
displayed when cycling through the directory. What happens is that it skips 
over the .tga's and displays the other image types instead.

What version of the product are you using? On what operating system?
stb-imv 1.01, windows 7, no freeimage

Please provide any additional information below.
It looks like there's a semicolon missing in the open filter at imv.c:2960 (ver 
1.01). I put one in and it seems to work now.