notle0n / betterchests Goto Github PK

View Code? Open in Web Editor NEW

5.0 1.0 0.0 154 KB

This is a Terraria mod which adds more sorting options for chests

Home Page: https://steamcommunity.com/sharedfiles/filedetails/?id=2563410612

License: GNU General Public License v3.0

C# 100.00%

tmodloader tmodloader-mod mod terraria terrariamod

betterchests's Introduction

Hi I'm Leon, or am I?

Some the projects I have worked on include but are not limited to:

Terraria mods
Die Deutsche Programmiersprache
Spiele Konsole
ModStatistics, tMLAPIs, tML-readme-card (ft. @bafto)
Minesweeper (overengineered scala implementation)
UIGenerator
hello-x
Smaller projects like: Subnetter, Leon's Game of life, QR-Code Scanner, youtube-downloader or Curve Painter

I have also contributed to these repositories:

Some fun stats:

Click the image for up to date stats

betterchests's People

Contributors

Stargazers

Watchers

betterchests's Issues

Item duping when holding rightclick on an item

My netcode sucks need to rewrite that probably

Shift + Right click items -> take half

Like in minecraft

Causing Crashes upon reloading world, specifically in host and play.

Me and my friends were doing a playthrough with this mod and kept getting the same error

System.NullReferenceException: Object reference not set to an instance of an object.

After doing more digging, we found that this was being caused by the BetterChests mod. I'll attach an entire log to sift through, but I believe it has something to do with UIs.
client.log

Buggy behaviour while interacting with furniture in certain situations

When hovering the cursor over storage furniture that's not loaded fully, it freezes the character in place and pauses actions like swinging a pickaxe until the cursor is moved away. Also neither the furniture nor the blocks it is on can be broken or used.

How to reproduce:

Run alongside Magic Builder https://steamcommunity.com/sharedfiles/filedetails/?id=3024322683
Build a structure that creates dressers (e.g. large house)
optional: disable Magic Builder
hover over dresser while standing nearby

Testing showed that manually placed dressers work as intended and that problem persists while Better Chests is the only mod installed.

[02:45:32.655] [Main Thread/WARN] [tML]: Silently Caught Exception: 
System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at BetterChests.Edits.ChestHoverEdits.MouseOver(Int32 i, Int32 j, Int32 type) in BetterChests\src\Edits\ChestHoverEdits.cs:line 29
   at Terraria.ModLoader.TileLoader.MouseOver(Int32 i, Int32 j) in tModLoader\Terraria\ModLoader\TileLoader.cs:line 947
   at Terraria.Player.TileInteractionsMouseOver(Int32 myX, Int32 myY) in tModLoader\Terraria\Player.cs:line 28250
   at Terraria.Player.TileInteractionsCheck(Int32 myX, Int32 myY) in tModLoader\Terraria\Player.cs:line 25574
   at Terraria.Player.LookForTileInteractions() in tModLoader\Terraria\Player.cs:line 25477
   at Terraria.Player.Update(Int32 i) in tModLoader\Terraria\Player.cs:line 22472
   at Terraria.Main.DoUpdateInWorld(Stopwatch sw) in tModLoader\Terraria\Main.cs:line 14967
   at Terraria.Main.DoUpdate(GameTime& gameTime) in tModLoader\Terraria\Main.cs:line 14603
   at Terraria.Main.Update(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 14141
   at Microsoft.Xna.Framework.Game.Tick() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 546
   at Microsoft.Xna.Framework.Game.RunLoop() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 878
   at Microsoft.Xna.Framework.Game.Run() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 419
   at Terraria.Program.RunGame() in tModLoader\Terraria\Program.cs:line 266
   at Terraria.Program.LaunchGame_(Boolean isServer) in tModLoader\Terraria\Program.cs:line 240
   at Terraria.Program.LaunchGame(String[] args, Boolean monoArgs) in tModLoader\Terraria\Program.cs:line 213
   at Terraria.MonoLaunch.Main_End(String[] args) in tModLoader\Terraria\MonoLaunch.cs:line 78
   at Terraria.MonoLaunch.<>c__DisplayClass1_0.<Main>b__1() in tModLoader\Terraria\MonoLaunch.cs:line 64
   at System.Threading.Thread.StartCallback()

Hover doesn't work on multiplayer sometimes

The hover to see items feature only works on multiplayer if another player has opened the chest before. If the chest unloads (?) the other player has to open it again for the feature to function.

Shift click items: Hotbar <-> Inventory

self explanitory. easy to implement.
discord requests thread: https://canary.discord.com/channels/103110554649894912/832559053515259944/937920496509542471

Multiplayer "loot all" being disabled.

I found a bug in multiplayer, if you click on "loot all" but press esc to close the chest when the confirmation button is up it will disable the "loot all" button from working for that session, it doesn't happen in single player though.

DepositAll/LootAll hotkeys deposit/loot piggybank even though it's not open

Needs testing.

Seems to be vanilla behavior. Snippet from ChestUI.LootAll:

for (int l = 0; l < 40; l++)
{
  if (player.bank.item[l].type > 0)
  {
    player.bank.item[l].position = player.Center;
    player.bank.item[l] = player.GetItem(Main.myPlayer, player.bank.item[l], false, false);
  }
}

There is no check if the player has the piggybank open or not.

Allow players to look into opened chests

Remove the checks for if other players have opened the chest. Uncertain how syncing affects this change.

Personal Chests

Idea

Users can mark Chests as their personal chest which prevents others from quick stacking into it. Trying to should give a error message along the lines "This chest is owned by ".
Hovering over the chest should also say who owns it.

Maybe expand the "Chest Lock" functionality to allow it to work on every chest the player owns and let owners open locked chests (naturally spawned chests are owned by nobody)

Implementation

Store a unique identifier for each Steam user in the world data for the chest. This data gets checked every time a personal action is taken.

Background for ChestHoverUI

A item slot background for every non-air item to prevent small items from blending into the background.