novus / unfinagled Goto Github PK

The server module provides a RunnableServer but no PlanServer. This makes swapping out servers less transparent.

Plans can be implemented as Services using the finagle RoutingService.

Plans can be implemented as Services using the finagle RoutingService.

This appears to be caused by ServerChannelFactory never being shutdown, which may indicate a problem with finagle's current implementation.

Reaching into the channel factory ( Netty3Listener.channelFactory.shutdown()) does solve the cpu issue, but as that this is a val it results in subsequent runs trying to use a factory that has been shutdown.

Providing a custom, isolated factory seemed like an obvious fix, but the private Closer class then attempts to close resources after they have been shutdown, resulting in exceptions.

Options:

• Patch finagled to make the factory val a def.
• Patch finagled to shutdown the factory in the closer.
• Patch finagled to allow control over the closer's role.
• Figure out netty's stateful steps and find a way to dance around this mess.

#5 originally replaced the lift/isDefinedAt sequence with applyOrElse, a 2.10 method. This ticket is a reminder to restore this after dropping 2.9 support as it is slightly more efficient.

Pass is an unfiltered response primitive allowing a plan to surrender control to the next available plan, even after having successfully matched the request.