Giter VIP home page Giter VIP logo

Comments (10)

audev avatar audev commented on July 25, 2024

@Robinlovelace Any reason to comment L96 in load.Rmd ?

# regions <- readOGR(file.path(pct_bigdata, "regions.geojson"), layer = "OGRGeoJSON

I've traced it back to this(386ff5f). Previously it was a more cautious if-else.

I was about to test some HEAT nos. and bumped into it.

from pct-scripts.

audev avatar audev commented on July 25, 2024

Asking not out curiosity: it prevents it from running! :0

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on July 25, 2024

@audev that line loads the old 'CUA' regional boundaries: https://github.com/npct/pct-bigdata/blob/master/regions.geojson

Now we use the new regional boundaries which I defined, of which there are 45. This is loaded here: 477b57a#diff-f728b105860d99bed1d5f0718c4ec40bR88

Update - it's loaded here (correct link): https://github.com/npct/pct-load/blame/master/load.Rmd#L87

from pct-scripts.

audev avatar audev commented on July 25, 2024

Problem is this: Before it read the json file only when geo_level == "cua", otherwise the json:

if(geo_level == "cua"){
  regions <- readOGR(dsn = file.path(pct_bigdata, "cuas-mf.geojson"), layer = "OGRGeoJSON")
  regions$Region <- regions$CTYUA12NM
}

 regions <- readOGR(file.path(pct_bigdata, "regions.geojson"), layer = "OGRGeoJSON")


Now it doesn't read it, as by default geo_level ='regions' . Am I missing sth? Or is it that pct-bigdata repository needs re-pulling?

from pct-scripts.

audev avatar audev commented on July 25, 2024

I've rerun and it's reading region_shape. No problem , thanks

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on July 25, 2024

No there was an issue with this: fixing it now, my bad.

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on July 25, 2024

Apologies - these are the correct regions and the new script loads them by default. I was playing around with geo_level = 'custom' and accidentally removed that part. Fixed here: 24c0852

from pct-scripts.

audev avatar audev commented on July 25, 2024

No worries, just wanted it for having real figures.

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on July 25, 2024

Done by @AnnaGoodman1 but still needs to be done...

from pct-scripts.

nikolai-b avatar nikolai-b commented on July 25, 2024

npct/pct-shiny#229

from pct-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.