Comments (10)
@Robinlovelace Any reason to comment L96 in load.Rmd ?
# regions <- readOGR(file.path(pct_bigdata, "regions.geojson"), layer = "OGRGeoJSON
I've traced it back to this(386ff5f). Previously it was a more cautious if-else.
I was about to test some HEAT nos. and bumped into it.
from pct-scripts.
Asking not out curiosity: it prevents it from running! :0
from pct-scripts.
@audev that line loads the old 'CUA' regional boundaries: https://github.com/npct/pct-bigdata/blob/master/regions.geojson
Now we use the new regional boundaries which I defined, of which there are 45. This is loaded here: 477b57a#diff-f728b105860d99bed1d5f0718c4ec40bR88
Update - it's loaded here (correct link): https://github.com/npct/pct-load/blame/master/load.Rmd#L87
from pct-scripts.
Problem is this: Before it read the json file only when geo_level == "cua", otherwise the json:
if(geo_level == "cua"){
regions <- readOGR(dsn = file.path(pct_bigdata, "cuas-mf.geojson"), layer = "OGRGeoJSON")
regions$Region <- regions$CTYUA12NM
}
regions <- readOGR(file.path(pct_bigdata, "regions.geojson"), layer = "OGRGeoJSON")
Now it doesn't read it, as by default geo_level ='regions' . Am I missing sth? Or is it that pct-bigdata repository needs re-pulling?
from pct-scripts.
I've rerun and it's reading region_shape. No problem , thanks
from pct-scripts.
No there was an issue with this: fixing it now, my bad.
from pct-scripts.
Apologies - these are the correct regions and the new script loads them by default. I was playing around with geo_level = 'custom'
and accidentally removed that part. Fixed here: 24c0852
from pct-scripts.
No worries, just wanted it for having real figures.
from pct-scripts.
Done by @AnnaGoodman1 but still needs to be done...
from pct-scripts.
from pct-scripts.
Related Issues (20)
- Update load.Rmd to fit the new directory structure
- Add intra-zone flows
- Add no fixed location flows to area estimates of cycling HOT 1
- govtarget in Kent HOT 1
- Explore using datastorr to store data HOT 2
- Use parallel for loop for overline funs
- Distance band graph goes negative in model output
- Clip zones to land area HOT 1
- Fix quiet routes in Cambridge HOT 13
- Fix lines for points that can't be routed
- Add education layer HOT 1
- Create test lsoa level data for V1.5 HOT 1
- Rnet goes nuts in some cases HOT 2
- Make all zones isolated HOT 8
- Move Coventry into Warwickshire
- Update model output tab HOT 8
- Cyclestreets API not working
- Produce a true list of dependancies HOT 2
- Build national rnets HOT 6
- need if statements in region stats HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pct-scripts.