nsforth / nmea0183 Goto Github PK

Motivation

I am currently using the nmea0183 crate for my project, which involves GPS data processing for spoofing detection. I've noticed that the crate lacks support for parsing GSV (Satellites in View) sentences.
Spoofing attacks involve the generation of fake GPS signals, and having detailed information about the visible satellites, including their the PRN numbers, elevations, azimuths, and SNR , is crucial for identifying and mitigating such attacks. The addition of GSV parsing support will significantly contribute to the crate's capabilities in the context of spoofing detection.

Proposed Changes

I propose adding a new module for GSV parsing and implementing the necessary logic to parse GSV sentences. This enhancement will not only complete the set of essential NMEA sentences but also empower the nmea0183 crate to play a more critical role in applications focused on GPS data integrity and security.

Checklist

• Discuss the proposed changes with the community and maintainers.
• Receive feedback and suggestions.
• Reach a consensus on the implementation approach.
• Proceed with implementing the changes and submitting a pull request.

Issue Summary

This issue is to request the addition of support for MTK NMEA Packet Protocol in the parser.

Proposed Changes

• Implement parsing logic for MTK-specific NMEA sentences.
• Add support for the $PMTKSPF sentence to extract jamming detection status.

Context

Currently, the parser lacks compatibility with MTK-based GPS modules, and users cannot access jamming detection status. The proposed changes aim to address this limitation.

fn main() {
    let line = "\u{3}$GPG\u{3}GA,1\u{3}5502\u{3}2.17\u{3}5,53\u{3}50.2\u{3}328,\u{3}N,02\u{3}728.\u{3}5283\u{3},E,1\u{3},5,1\u{2}.4\u{3}0,24\u{3}1.3,\u{3}M,26\u{3}.4,M\u{3},,*5\u{3}1\r\n";

    for result in Parser::new().parse_from_bytes(line.as_bytes()) {
        println!("{:?}", result);
    }
}

thread 'main' panicked at 'index out of bounds: the len is 79 but the index is 79', /Users/vadzim/.cargo/registry/src/github.com-1ecc6299db9ec823/nmea0183-0.2.1/src/lib.rs:355:21

Thanks for this library - it's saved me effort in getting a small embedded GPS device up and running.

One issue is that the number of satellites being received is part of the GGA message, but the parser only returns GGA results once a fix is available.

A solution would be to have the parser output 2 types of GGA messages, with and without a fix. ie change to something like:

pub enum ParseResult {
    RMC(Option<RMC>),
    GGA(GGA),
    GGANoFix(GGANoFix),
    GLL(Option<GLL>),
    VTG(Option<VTG>),
}

pub struct GGANoFix {
    pub sat_in_use: u8,
}

Is this a reasonably solution? Would you accept a PR for this?

The parse_from_hhmmss function in the NMEA parser library contains a conditional check that limits the range of minutes to be less than 59. This condition is incorrect as it should be m < 60 to include minutes ranging from 0 to 59.