nsidc / agu-2019-nsidc-data-tutorial Goto Github PK

I'm adding comments as issues so that there is a record. Feel free to ignore or adopt. However, I will try to emphasize points I think are important. I'll start with some general comments and add specific comments as separate issues.

What are the main "teaching" outcomes for this notebook? I would suggest pairing the notebook down to meeting just these objectives by stripping out any extra code, so that trying to understand syntax does get in the way of understanding what needs to be done to download data.

I would suggest focusing on just one data set. If data for the tutorial are going to be on AWS then there is no need to download all 4 data sets. If you want to provide a way for students to download all the data, then you can provide a script rather than a notebook to do this.

I think it is worth trying to be as "pythonic" as possible. You're not trying to teach python but you should follow "best practices". Maybe the devs can go through this once the structure is there.