I added a <a href="https://github.com/NTU-ALComLab/LSV-PA/blob/master/lsv_fall_2021/ad

Thanks. It is a good observation. You may refer to <a href="https://github.com/NTU-AL

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

PA1 reference answers and grading script about lsv-pa HOT 2 CLOSED

ntu-alcomlab commented on June 30, 2024

PA1 reference answers and grading script

from lsv-pa.

Comments (2)

Luo-Yun-Rong commented on June 30, 2024 3

Thanks. It is a good observation. You may refer to abc.h and notice that objects may have following types.

// object types
typedef enum { 
    ABC_OBJ_NONE = 0,   //  0:  unknown
    ABC_OBJ_CONST1,     //  1:  constant 1 node (AIG only)
    ABC_OBJ_PI,         //  2:  primary input terminal
    ABC_OBJ_PO,         //  3:  primary output terminal
    ....
    ABC_OBJ_NODE,       //  7:  node
    ....
} Abc_ObjType_t;

The iterator Abc_NtkForEachNode only gives you objects with type ABC_OBJ_NODE.

#define Abc_NtkForEachNode( pNtk, pNode, i )                                                       \
    for ( i = 0; (i < Vec_PtrSize((pNtk)->vObjs)) && (((pNode) = Abc_NtkObj(pNtk, i)), 1); i++ )   \
        if ( (pNode) == NULL || !Abc_ObjIsNode(pNode) ) {} else

static inline int   Abc_ObjIsNode( Abc_Obj_t * pObj )   { return pObj->Type == ABC_OBJ_NODE;    }

You may miss the constant object with type ABC_OBJ_CONST1.

from lsv-pa.

kevinchang73 commented on June 30, 2024

@Luo-Yun-Rong Hi TA, for the case "ctrl.aig", the reference answer tells the first MSFC is {n0}. However, there is no "n0" node when I use lsv_print_nodes (the example command). Similar situations also occur in "i2c", "mem_ctrl", "router" and "square". So, I wonder if Abc_NtkForEachNode may miss some nodes or the answers may be incorrect? Thanks a lot!

from lsv-pa.

Recommend Projects