nuget / home Goto Github PK

If the dependent package such as Microsoft.aspnet.mvc lives in a folder and use that folder as the primary package source, resolver gather will throw null reference exception at line 40:

        var packageWithNoDependencyInfoInPrimary = (primaryPackages.Where(p => !primaryRepoPackageDependencyInfo
            .Any(pdi => new PackageIdentity(pdi.Id, pdi.Version).Equals(p)))).FirstOrDefault();

here primaryRepoPackageDependencyInfo is null for a local folder repo, because primarySource.GetResource() returns null.

We should do a null check and also process this scenario accordingly.

Repro step:
install-package https://az320820.vo.msecnd.net/packages/microsoft.aspnet.mvc.4.0.20505.nupkg

type above on PMC.

NuGet.PackageManagement: Need to support rollback on install

NuGet.PackageManagement: Uninstalling a package with uninstall.ps1 from powershell console fails

Just install and uninstall jQuery from powershell console. Uninstall will work fine but uninstall.ps1 will fail to execute. This is because, in powershell console, today, powershell scripts get executed as post-step at the end in order to avoid thread switching. This does not work for executing uninstall.ps1 since the package directory is already deleted

We have to be able to invoke methods on the powershell dispatcher

NuGet.PackageManagement: Readme.txt and BindingRedirects should only be executed once per user action

on NuGetPackageManager's PreviewInstallPackageAsyncPrivate method, the call of
IEnumerable newListOfInstalledPackages = packageResolver.Resolve(packageTargetsForResolver, availablePackageDependencyInfoWithSourceSet, projectInstalledPackageReferences, token);

returns wrong results.
It should have returned jquery.2.1.3 as one of package identities, now it returns jquery.1.4.4.

jQuery 2.1.3 was removed from the following lines of code, which should not be.

                if(installedPackageWithSameId != null)
                {
                    packageTargetsForResolver.Remove(installedPackageWithSameId);
                }

Repro steps:

1. Install-package jquery.validation
2. Update-package jquery

Expected: updates jquery to 2.1.3
Actual: preview install action (install by Id) returns 0 actions.

Need to update the logic. So it returns folder\projectName for these insider a folder.

NuGet.Configuration: Methods on ISettings such as SetValue, DeleteValue should be async

NuGet.PackageManagement: Use DownloadResource.Progress event

Repro steps

1. Create a console application
2. From the powershell console, install a fairly large package, say, EntityFramework

Expected:

1. There is a progress bar at the bottom-right of powershell console

Actual:

1. There is no progress bar at the bottom-right of powershell console. When downloading a large package, there is no visual feedback to the user

Sometimes people type in incorrect input for -source switch, which will cause creation of V2 repository to fail.

It now will crash VS after debug.assert.

The order of operations shown in the preview should be:

1. Uninstalling
2. Updating
3. Installing

I thought we displayed packages that were being updated, but I don't see an Updating header anymore. If that's gone, then the order should be:

1. Uninstalling
2. Installing

Binding-Redirects with dependent projects does not work as desired
And, BindingRedirects should only be executed once per user action

NuGet.PackageManagement: Not execute init.ps1 of a package, if it is already installed once in a solution

NuGet.Packaging: Issue reading nuspec files with certain namespaces

After installing the latest version of a package, the following happens:

1. The Action changes to "Update"
2. The Version changes to the previous version
3. The button changes to "Update"

When selecting a package that is already installed, here's what I'm thinking we should do:

1. If there is an update available, select the latest version (respecting prerelease checkbox) and set the action to Update.
2. If the latest version is already installed, set the action to Uninstall.

Install-package testpackage.overwritetest or use UI to install this package with prompt user selected.

Expected: prompt user to choose overwrite or ignore the file in the package

Actual: nothing happens

NuGet.PackageManagement: Uninstalling satellite packages

in solution explorer.

Right now it's not.

so that for the scenario of update-package, it won't throw InvalidOperation of package already exist.
Instead, we should print a message of no package updates available.

NuGet.Packaging: Satellite package which does not have exact version of runtime package in dependency version spec do not work

while it should not be.

NuGet.PackageManagement: If restoring a package fails, satellite files for the successfully restored packages are not restored

Repro steps:

1. Create a console Application
2. Install-Package Microsoft.AspNet.Razor.fr
3. Install one or more packages from a private feed such that it is not available from NuGet official
4. Now, disable the private feed and only retain the official feed
5. Delete packages folder
6. Initiate restore packages through build or using 'Restore' button on the UI window
7. Package restore will fail for all the packages from the private feed

Expected:

Satellite files for the Microsoft.AspNet.Razor.Fr is copied successfully

Actual:

Satellite files are not copied for Microsoft.AspNet.Razor.Fr and it never becomes available for restore again

NuGet.Frameworks: Framework reducer returns nothing when net40 and net40-client are present in the package

Repro:

1. Install log4net 2.0.2 (the latest version is 2.0.3)
2. Select the Installed filter

Expected:

1. log4net would show with the update available glyph

Actual:

1. log4net shows up with the installed/latest checkmark glyph

reported by Fei