Giter VIP home page Giter VIP logo

Comments (7)

Caeden117 avatar Caeden117 commented on August 21, 2024 1

I have been made aware and have some ideas to try and fix this

from countersplus.

Caeden117 avatar Caeden117 commented on August 21, 2024 1

Turns out that didnt work. I'm trying out more stuff now

from countersplus.

Caeden117 avatar Caeden117 commented on August 21, 2024 1

With this final commit, I am pleased to say that this bug has been fixed for good in 1.3.0.

https://www.modsaber.org/mod/countersplus/1.3.0

I had to redo Config to fix it, but it's done.

from countersplus.

Caeden117 avatar Caeden117 commented on August 21, 2024 1

No, that's intentional. By "Override" I meant "Use". I'll change the label for it.

from countersplus.

Caeden117 avatar Caeden117 commented on August 21, 2024

Should now be fixed. Try using this build and see if that fixes it.
CountersPlus.zip

from countersplus.

xhuytox avatar xhuytox commented on August 21, 2024

Just tested. The settings are now saved correctly whenever. Thank you for all your work!

One possible bug. I noticed you fixed it so now the custom Score Counter shows both the score and the rank. That's awesome. While testing this, I noticed that the Override Base Counter setting inside the Score Counter tab is now the inverse of how it use to be. Now, when this is true, it shows the base game's score counter, and when it's false, it shows the custom counter. This seems like the opposite of what I thought this setting would do.

from countersplus.

xhuytox avatar xhuytox commented on August 21, 2024

I think you should either change the label of the setting to "Use Base Game Counter" here:
https://github.com/Caeden117/CountersPlus/blob/c6ea4e1302139a9815f14b0c7fc4e3490bfde645/Counters%2B/CountersSettingsUI.cs#L79

or return the inverse of "UseOld" here:
https://github.com/Caeden117/CountersPlus/blob/c6ea4e1302139a9815f14b0c7fc4e3490bfde645/Counters%2B/CountersSettingsUI.cs#L80

from countersplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.