nurodev / next-define Goto Github PK

What's the issue?

Currently when using definePage, either for the pages/ or app directory, if you add any argument to the handler, like to get the params from getStaticPaths or accessing the req for getServerSideProps, then the inferred props for Component break.

To break down what I have worked out so far:

• The order you add additional properties to the options parameter can affect whether the type inference works (See example).
  • My guess is some kind of loop hierarchy bug where because getServerSideProps is before Component it knows to check for inferred props first, but when getServerSideProps is defined after Component it doesn't know getServerSideProps exists to fails over to the default of Record<string, any>?
• Only happens when adding a parameter to a handler function, like { params } to getStaticProps.

TS Playground example

I also tried creating a discriminated union type to work around the issue but somehow it broke even more.

Example

✅ This one works perfectly fine

const { Component, getServerSideProps } = defineSSR({
	getServerSideProps: (ctx) => ({ props: { foo: "bar" } }),
	Component: (props) => <>Hello {props.foo}</>,
});

❌ This one does not & sets props to Record<string, any>

const { Component, getServerSideProps } = defineSSR({
	Component: (props) => <>Hello {props.foo}</>,
	getServerSideProps: (ctx) => ({ props: { foo: "bar" } }),
});