nus-cs2113-ay2021s1 / tp Goto Github PK

Hello~ Some comments for your DG

1. For the sequence diagram under Design > Architecture, remember to put colon in front of the Class name, even if there is no name.

2. For the class diagram under Design > Ui component, make sure to use the notations covered in the module! As explained in class, it can be considered as a bug when you use different notation.

3. Are the '+' icon for this class diagram supposed to be here? Also I see that this is a simplified diagram of the more detailed one below. Maybe you can put note note or write a sentence below the diagram saying like "This is a simplified view, to see a detailed view, look at figure x).
   

4. For SD create, not too big of an issue but the bar seems to be cut off abit.

5. For the SD of usage, since Applicance is an abstract class then are these methods static methods? I.e. getName(), getLocation() etc. Also the dotted line is interrupted so do take note to join it back.

Good job on the DG! Also just a tip, while testing your application, there may be a scenario where the user may think this is a bug while you may not. So for this kind of situations, what you should do is to write it down in the UG.