nus-mtp / attack-on-tutor Goto Github PK

Socket listeners are getting a bit messy.
Should be separated out by client and component.

• Eg. Chat, Tutor Client, Student Client, etc.

The sockets exist, but they mysteriously disappear on their own after a while.

• Is this a socket.io thing? I'm not sure.

Questions sent by the tutor are all lost when the student client refreshes the page.

• Questions are stored on the server side, however this information isn't relayed back to the students when they rejoin the lobby.
• They are also removed from groups in socket io.
• Do we send them the questions when they are added back into a group that has questions sent to the group?

Dear self, please fix this

Deleting groups within the lobby after questions have already been sent the groups is weird and finicky.

• Questions sent to a specific group remain after the group has been deleted.
• The student clients cannot update their questions if the group has been deleted.

When a user is in two or more different groups and the tutor sends a question to these groups, the user receives duplicates of the same question.

So errors aren't so ugly

Currently the javascript and the css for the views are all put within the same file.
It's too huge and messy and should be separated out during refactoring. HOPEFULLY SOON.

To make life easier for all of us

Appears to be unnecessary now that auth is implemented? Or is it necessary?

To minimize its ugliness

If I were to post an initial question, and then have a student answer before refreshing, the second question will be bugged (at the answering phase); the student will be unable to submit their answer.

Current Workaround: Refresh both the views of the tutor and the student.

We should probably... be able to... logout by now 😢

Optimize?

Students assigned to multiple groups that receive questions will only be able to attempt the question with one of their groups.

• Eg. a Student M is assigned to both Group A and B
• Tutor sends a question to Groups A and B
• Student M will only be able to attempt the question in the group that was first assigned to them.

It seems a solution would be to prevent a student from being in multiple groups concurrently?
Is there a possibility that a student is required to be in more than one subgroup within the tutorial?