nus-mtp / bill-organizer Goto Github PK

While @dev-seahouse has solved CircleCI's problem in this commit, it caused the assets compilation in Heroku to break because the cross-env.js in Heroku is still in the bin folder, not dist/bin

definition of done:

1. the config file is supported by sublime text, phpstorm, atom , bracket
2. the config file is supported by npm so that code formatting and style check can be automated prior git push. (this is to prevent unnecessary git conflicts due to an extra space here and there)
3. code style/format testing can be performed automatically via laravel mix command, e.g npm run production. (this is to provide extra protection against stuff like 'oh no i forgot to auto-format before commit')
4. 1-4 is fulfilled for each of the language/syntax
   4.1 javascript(es6) /jquery
   4.2 sass(sassy css)
   4.3 blade/html5
   4.4 php

alternative: take sample config file from any 1 formatter, convert to the config required by our favorite editors + npm build individually

apparently semantic's is buggy and tells you that passwords are mismatched no matter what you put

i guess i'll fiddle with it a bit more later before writing my own jquery validation OTL

https://devcenter.heroku.com/articles/ssl

definitions of done:

1. semantic ui sass files are able to be automatically compiled into public/css folder by running npm run production
2. semantic html elements styled with semantic ui are able to be displayed as expected with no error (as shown in chrome developer console )

refer to https://github.com/nus-mtp/bill-organizer/blob/55e93c199836c1daed793423d8eb5bbf9139a8ca/resources/views/layouts/app.blade.php line 32 - line 127

Memory error happens when building commit 4e74d51

• drag and drop file into upload area
• front end format validation/rejection/message
• do not upload yet and display pdf preview of file
• hook up preview area to extract pdf, return selection object
• send server upload request
• server store file in session
• server takes in file, duplicate check, validation -> store pesistence
• .done(doAjaxUpload()).fail(showFailureMessage()).sucess(otherActions())

Maybe change text color to something contrast green?

Definition of done:

1. the linter is able to be run via nodejs npm command. ideally via laravel 5.4 mix (webpack base)
2. the linter can correctly detect syntax errors under laravel environment
3. the linter is configured in circleci to be run before deploy, reject if lint failed
4. 1-3 is fulfilled for the following language

• sass
• blade
• javascript(es6)/jquery
• php

5. (optional) the linter and its config file is available as plugin in sublime text, atom, phpstorm and bracket, or most of them

• createRecord
• editRecord
• login
• registration

definition of done:

1. a central database is configured and open for connection
2. everyone in the team is able to connect to database via provided db address, username and password
3. database related operations can be performed by laravel using Eloquent with no DB connection exception
4. circle ci is able to access the configured database ( proper settings are configured in circle.yml file)

Some settings are specified in circle.yml, some are specified in the project settings in circle website. Let's not have the configurations all over the place, which is extremely confusing. Extract the configs in website to circle.yml.

the retractable area that is supposed to display stats

Some code in backend reference the same string literal in multiple places. This is a recipe for disaster. When we decide to change the string one day, we'll have to make sure that we change it in all occurrences in the code. It's better to extract the constants in one place.

Ever since public/css and public/js folder is git-ignored, heroku couldn't serve the compiled assets.

• fix the problem of icon image not loading

Landing Page

• automatically redirect to '/dashboard' if user is logged in

Dashboard

• add "upload bill" button
• add clickable placeholder billing organisation that will link to billing organisation page

I have came to realize that I might have used the wrong naming conventions for PHP

• createRecord
• registration
• editRecord (example done)

content containers are currently manually padded to make space for the fixed top menu
switch to using semantic's padded segments for more convenience! (ﾉ^ヮ^)ﾉ*:・ﾟ✧

public folder is excluded from ci pipeline, however, icons/images are manually placed inside public folder(not compiled)

asset()

Generate a URL for an asset using the current scheme of the request (HTTP or HTTPS):

$url = asset('img/photo.jpg');

secure_asset()

Generate a URL for an asset using HTTPS:

echo secure_asset('foo/bar.zip', $title, $attributes = []);

I'll separate the task one-by-one later but for now I'll dump everything here

TODO:

1. Fix bug in UpdateRecordForm
2. UpdateRecordForm's authorization and validation rules
3. Fix bug in RecordController upload_file
4. Decide once and for all the type of Record's issue_date, due_date, and period (this is causing a lot of overhead)
5. When using factory(Record::class), need to adjust due_date to matach the record_issuer type -> a lot of code and repeated in UserRecordIssuerControllerTest as well as RecordControllerTest (fix the pitfall of the Record Factory)
6. Update should redirect to record issuer page

Should start adding tests to backend. We don't want to develop a new feature and break something.

description:

we need to display user proper error messages such like sorry you are not authorised, page not found , oops there's some error to use instead of currently showing wall of codes. before this can be done these user friendly error pages need to be prepared

definition of done:

• the pages conform modern design
• place the html files with inline view inside resources/views folder

• bill organizations get squahed together on small screen - >try to use media queries set 2 columns instead 4 on small screen

@eatedcookie has some problem with her DB and we've solved it. The fix is in this commit: 40dae03.

Let's make it OS specific (WIndows in particular) so it doesn't interfere with other OSes.

php version : 7.1.2
OS: archlinux

PHP Notice:  Undefined index: port in /home/kenan/gitrepos/sites/bill-organizer/config/database.php on line 7
PHP Stack trace:
PHP   1. {main}() /home/kenan/gitrepos/sites/bill-organizer/artisan:0
PHP   2. Illuminate\Foundation\Console\Kernel->handle() /home/kenan/gitrepos/sites/bill-organizer/artisan:35
PHP   3. Illuminate\Foundation\Console\Kernel->bootstrap() /home/kenan/gitrepos/sites/bill-organizer/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:115
PHP   4. Illuminate\Foundation\Application->bootstrapWith() /home/kenan/gitrepos/sites/bill-organizer/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:270
PHP   5. Illuminate\Foundation\Bootstrap\LoadConfiguration->bootstrap() /home/kenan/gitrepos/sites/bill-organizer/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:208
PHP   6. Illuminate\Foundation\Bootstrap\LoadConfiguration->loadConfigurationFiles() /home/kenan/gitrepos/sites/bill-organizer/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php:38
PHP   7. require() /home/kenan/gitrepos/sites/bill-organizer/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php:63
Migration table created successfully.
Migrated: 2014_10_12_000000_create_users_table
Migrated: 2014_10_12_100000_create_password_resets_table
Migrated: 2017_02_23_100152_create_record_issuer_types_table
Migrated: 2017_02_23_102303_create_user_record_issuers_table
Migrated: 2017_02_23_102304_create_records_table

in branch feature/reg-login-ui-new
welcome page not using default layout --> js files are not there --> register and login modals not working.
anyone got alternative ways other than just hardcode the links in?

A user will expect this to be clickable.

https://laravel.com/docs/5.4/validation

• createRecord
• editRecord
• login
• registration

https://laravel.com/docs/5.4/passwords
video tutorial: https://www.youtube.com/watch?v=tFHMdYDULOc

branch: assetLoadingAcrossPage