nus-mtp / x-aurora Goto Github PK

@khlee1886 Your Part is ok, but still have magic strings/numbers. Also, comments may be insufficient to describe 'what to do' in your program. Logging is missing in your component.
Possible recommendation: Eliminate magic strings and numbers. Try to implement logging in your part.

@JohannLee The comment in your part is inconsistent. Your component is not tested and cleaned. Also, the logging is missing.
Possible recommendation: do as much as you can.

@eang0322 NIL

Please add descriptions to your code so that other developers can understand what you are doing.

As current design is going to use system current time and the source URL of the website as the ID. And unknown URL will be set to a default value. If the attacker changes the current system time. It would have probability that duplicated data file ID (which is the data file name) will be created (like unknown url + same amended system time). This may damage the integrity of the data file of other users. (Write to myself to fix this: use the time value retrieved from the timer server to be the more accurate current time. In case of no Internet access, use the system time since there is no other choice. )

The current system could not handle empty data, null data, empty url, null url. The correct way to handle these cases are to abort data file creation and indexing system insertion when the system faces these situation.
(Write to myself to fix in case I may forget: more assertions, accept empty url but put a default to it, make sure the generated file name is not empty and null. Make sure the id is not empty and null, if id is empty, which implies content is empty => abort the data file creation)

Please use standard format such as javadoc to comment your methods and classes. (I am OK with other formats, as long as it is consistently used within the project).

@JohannLee
Please read very carefully and do certain modifications to your part BEFORE THE DEMO
The sending of extracted text from browser => remains the same
The reply will be different. genOutput now becomes ArrayList and outputs the contents line by lines.

The receiving and replying for editor plugin will be different. Please read the format within the Implementation and do the respective modification.

Also, now the communicator can initiates communications when the user changes his/her preference setting. Please take note of that and do modification on that.

ALL THESE CHANGES MUST BE FINISHED BEFORE THE FINAL DEMO!!!