Debug doesn't restore block properly when 2 slabs about npc_destinations2 HOT 8 CLOSED

Yeah, I just send packets to the client to make that debug path. I will see what I can come up with for it. Just be a few, i'm swamped :(

from npc_destinations2.

No problems, I'm impressed with everything so far. I'm actually going to see if I can compile this and submit a PR for this issue. Just raising the issue so we have a trail.

from npc_destinations2.

Ok I'm going to have to admit defeat. I can't work out how to compile this whilst respecting all the different API's, without totally pulling everything apart into separate maven modules and shading them together at the end. Tell me your secret :)

from npc_destinations2.

Sadly, it's not a maven project. I've thought about converting it, but like with all things of late. A lack of time.

The lines that are the issue, least should be.
CitizensProcessing:513
and
CitizensProcessing:528

I will check it out later on and see what the deal is with it. That method is depreciated anyway, so there is a good chance I need to change it.

from npc_destinations2.

Ok, I managed to compile it. I had to set it up for Maven though but I hope I can pull my changes back to your form for anything I do. If you're interested in the mavenized version you can find it at: https://github.com/bundabrg/NPC_Destinations2/tree/maven/master (I can provide a PR if you like but I'm not confident about my maven skills ;-)

I'll take a check about fixing this issue which I'm sure should be easy and then work on what I actually did that work for.

from npc_destinations2.

Tested with 1.13 PaperMC and 1.12.2 PaperMC, which use alternative methods. I cherry picked this from my maven tree so hopefully it works in the pristine source.

from npc_destinations2.

Sweet, I will move that into the version code.

from npc_destinations2.

Changed a bit on this, it should be ok with how it is doing it. The issue now lies in 1.13 and how it manages linked tiles. That one is becoming a bit of a pain. Going to close this as the general function is resolved, but there is a lingering issue with connected tiles.

from npc_destinations2.