nventive / extendedsplashscreen Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 1.01 MB

Display a loading indicator on top of the native mobile splash screen during your app initialization

License: Apache License 2.0

C# 100.00%

android dotnet ios mobile uno-platform uwp

extendedsplashscreen's People

Contributors

Watchers

Forkers

workgroupengineering

extendedsplashscreen's Issues

[Android] Bottom visible bounds not respected in app

Expected Behavior

When following the readme's instructions and adding the following line to the app, the app still takes into account the bottom notch on Android:

protected override void OnCreate(Bundle bundle)
{
	Nventive.ExtendedSplashScreen.ExtendedSplashScreen.AndroidSplashScreen = AndroidX.Core.SplashScreen.SplashScreen.InstallSplashScreen(this);
	base.OnCreate(bundle);
}

Actual Behavior

When following the readme's instructions and adding the following line to the app, the app's content is partially hidden by the bottom notch on Android

protected override void OnCreate(Bundle bundle)
{
	Nventive.ExtendedSplashScreen.ExtendedSplashScreen.AndroidSplashScreen = AndroidX.Core.SplashScreen.SplashScreen.InstallSplashScreen(this);
	base.OnCreate(bundle);
}

screen-20240129-162140.mp4

Steps to Reproduce the Problem

Update the code of the sample in this repo with the following changes:

public class MainActivity : Microsoft.UI.Xaml.ApplicationActivity
{
	protected override void OnCreate(Bundle bundle)
	{
		Nventive.ExtendedSplashScreen.ExtendedSplashScreen.AndroidSplashScreen = AndroidX.Core.SplashScreen.SplashScreen.InstallSplashScreen(this);
		base.OnCreate(bundle);
	}
}

<Page x:Class="ExtendedSlashScreen.Uno.Samples.MainPage"
      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
      xmlns:nventive="using:Nventive.ExtendedSplashScreen"
      xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
      xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
      mc:Ignorable="d">

	<TextBlock Text="Hello, world!"
			   FontSize="30"
			   VerticalAlignment="Bottom"
			   Foreground="Red"/>
</Page>

Launch the app on an Android device with the bottom notch (e.g. Pixel 6)

Specifications

Version: latest version of main
Platform: Android
Subsystem:

TODO: README

Expected Behavior

README should explain how to use the package

Actual Behavior

readme is empty

crash with java.lang.IllegalArgumentException: width and height must be > 0

Expected Behavior

If in some rare case when bitmap is not loaded code must exit gratefully or load an empty bitmap.

Actual Behavior

Crashes the app. Observed only in customer crash reports.

Steps to Reproduce the Problem

Check logs from customers.
See rare crash in logs;

Specifications

Version: ExtendedSplashScreen.Uno.WinUI Version="0.5.0-dev.60"
Platform: Android 14
Observer on physical devices with frequencies:

Device              OS         Counts
-------------------------------------
Pixel 7 Pro         Android 14  10
Galaxy S21 Ultra 5G Android 14  1
Pixel 6             Android 14  1

Stack Trace

Java.Interop.JniEnvironment.StaticMethods.CallStaticObjectMethod(JniObjectReference , JniMethodInfo , JniArgumentValue* )
Java.Interop.JniPeerMembers.JniStaticMethods.InvokeObjectMethod(String , JniArgumentValue* )
Android.Graphics.Bitmap.CreateBitmap(Int32 , Int32 , Config )
Nventive.ExtendedSplashScreen.ExtendedSplashScreen.GetBitmapFromView(View view)
Nventive.ExtendedSplashScreen.ExtendedSplashScreen.OnExitAnimation(Object sender, ExitAnimationEventArgs e)
AndroidX.Core.SplashScreen.SplashScreen.IOnExitAnimationListenerImplementor.OnSplashScreenExit(SplashScreenViewProvider )
AndroidX.Core.SplashScreen.SplashScreen.IOnExitAnimationListenerInvoker.n_OnSplashScreenExit_Landroidx_core_splashscreen_SplashScreenViewProvider_(IntPtr , IntPtr , IntPtr )
Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPL_V(_JniMarshal_PPL_V , IntPtr , IntPtr , IntPtr )
java.lang.IllegalArgumentException: width and height must be > 0
android.graphics.Bitmap.createBitmap Bitmap.java:1197
android.graphics.Bitmap.createBitmap Bitmap.java:1163
android.graphics.Bitmap.createBitmap Bitmap.java:1111
android.graphics.Bitmap.createBitmap Bitmap.java:1070
mono.androidx.core.splashscreen.SplashScreen_OnExitAnimationListenerImplementor.n_onSplashScreenExit(Native Method)
mono.androidx.core.splashscreen.SplashScreen_OnExitAnimationListenerImplementor.onSplashScreenExit SplashScreen_OnExitAnimationListenerImplementor.java:31
androidx.core.splashscreen.SplashScreen$Impl31.setOnExitAnimationListener$lambda-0(SplashScreen.kt:459)
androidx.core.splashscreen.SplashScreen$Impl31.$r8$lambda$_AQ1xSddL7-kLq4WrGTBd4lTQaY(Unknown Source:0)
androidx.core.splashscreen.SplashScreen$Impl31$$ExternalSyntheticLambda0.onSplashScreenExit(Unknown Source:4)
android.window.SplashScreen$SplashScreenManagerGlobal.dispatchOnExitAnimation SplashScreen.java:271
android.window.SplashScreen$SplashScreenManagerGlobal.handOverSplashScreenView SplashScreen.java:258
android.app.ActivityThread.reportSplashscreenViewShown ActivityThread.java:4257
android.app.ActivityThread.lambda$syncTransferSplashscreenViewTransaction$1 ActivityThread.java:4274
android.app.ActivityThread.$r8$lambda$zFMoOisyD5hrqE37Jh7SYYMQGB8(Unknown Source:0)
android.app.ActivityThread$$ExternalSyntheticLambda5.run(Unknown Source:6)
android.view.Choreographer$CallbackRecord.run Choreographer.java:1339
android.view.Choreographer$CallbackRecord.run Choreographer.java:1348
android.view.Choreographer.doCallbacks Choreographer.java:952
android.view.Choreographer.doFrame Choreographer.java:878
android.view.Choreographer$FrameDisplayEventReceiver.run Choreographer.java:1322
android.os.Handler.handleCallback Handler.java:958
android.os.Handler.dispatchMessage Handler.java:99
android.os.Looper.loopOnce Looper.java:205
android.os.Looper.loop Looper.java:294
android.app.ActivityThread.main ActivityThread.java:8177
java.lang.reflect.Method.invoke(Native Method)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run RuntimeInit.java:552
com.android.internal.os.ZygoteInit.main ZygoteInit.java:971

Dependabot couldn't find a <anything>.(cs|vb|fs)proj for this project

Dependabot couldn't find a .(cs|vb|fs)proj for this project.

Dependabot requires a .(cs|vb|fs)proj to evaluate your project's current .NET dependencies. It had expected to find one at the path: /<anything>.(cs|vb|fs)proj.

If this isn't a .NET project, or if it is a library, you may wish to disable updates for it in the .dependabot/config.yml file in this repo.

View the update logs.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.