nvie / simpleaes Goto Github PK

Thank you for writing this very simple but highly effective module.. As much as I love Python and always will do, it's the lack of simple helpers like this that really annoy me. Good work! 👍

I presume that there is one, as it's on pypi. Could you please push the tag here?

We have been using SimpleAES and I noticed it was using a process to run OpenSSL to do the encryption. We noticed the encryption seeming slow so I created a quick benchmark to see how the speed of this compares to using pycrypto.

The results of the benchmark against the latest version of SimpleAES does not look good:

Each of the above 30 runs were run in random, non-consecutive order by
benchmark v0.1.5 (http://jspi.es/benchmark) with Python 2.7.2
Darwin-12.3.0-x86_64 on 2013-05-29 09:47:26.

Running the same benchmark against SimpleAES==0.1 looks much better:

Each of the above 30 runs were run in random, non-consecutive order by
benchmark v0.1.5 (http://jspi.es/benchmark) with Python 2.7.2
Darwin-12.3.0-x86_64 on 2013-05-29 09:45:26.

My suspicion is that it is not OpenSSL that is slow but the overhead of starting a new sub process to run OpenSSL is slower

Hi, picture worth thousand word, so i'll try to be quick:

PYTHON 2.7.9

Python 2.7.9 (default, Mar 1 2015, 12:57:24)
[GCC 4.9.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.

from SimpleAES import SimpleAES
aes = SimpleAES("isdefinitelynot4u2no")
aes.decrypt("U2FsdGVkX1+eUdcEgzX6WUVO0xmuShSzlHWHlZVoVC8=")
'codewie\n'

PYTHON 2.7.12

+Python 2.7.12 (default, Jun 29 2016, 08:57:23)
[GCC 5.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.

from SimpleAES import SimpleAES
aes = SimpleAES("isdefinitelynot4u2no")
aes.decrypt("U2FsdGVkX1+eUdcEgzX6WUVO0xmuShSzlHWHlZVoVC8=")
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/site-packages/SimpleAES/init.py", line 71, in decrypt
raise DecryptionError('Could not decrypt.')
SimpleAES.exceptions.DecryptionError: Could not decrypt.

Adding the fact that we can't encrypt either

Python 2.7.12 (default, Jun 29 2016, 08:57:23)
[GCC 5.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.

from SimpleAES import SimpleAES
key = 'Some arbitrary bytestring.'
aes = SimpleAES(key)
aes.encrypt('My secret plaintext data')
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python2.7/site-packages/SimpleAES/init.py", line 54, in encrypt
raise EncryptionError('Could not encrypt.')
SimpleAES.exceptions.EncryptionError: Could not encrypt.

Could you have a look at it, you rely on pycrypto, so could it be this library that is failing?

Thanks and Regards

Full discussion can be found here;
http://lists.unbit.it/pipermail/uwsgi/2012-November/005043.html

Seems that using subprocess.Popen causes some threading problems... Might be worth mentioning on the README that this library uses subprocess

Cal