Giter VIP home page Giter VIP logo

Comments (5)

fdschmidt93 avatar fdschmidt93 commented on May 27, 2024 1

https://neovim.discourse.group/t/neovim-0-6-stabilization-period-begins-today-10-31-2021/1329

Ok, I'm more leaning to not fix this, because the file browser will be removed mid December from telescope by when 0.6 will be hopefully released.

Given the quite significant difference in implementation, I'd have to rewrite some of the actions, which is too much time for me right now for something that'll fix itself too soon enough I'm afraid. I realize it is not satisfying for 0.5.1 users but I have to be practical with the time I have right now. My sincerest apologies.

I'll make a disclaimer on the README and would be happy to accept a PR to have a compat branch or so.

from telescope-file-browser.nvim.

j-hui avatar j-hui commented on May 27, 2024 1

For what it's worth @fdschmidt93 this works on both 0.5.1 and 0.6.0 (it prints the address of the function):

x = vim.ui and vim.ui.input or vim.fn.input
print(x)

No worries about not having the fix for 0.5! I'm still a new user of this plugin (and the entire Telescope ecosystem), and as you said 0.6 should be coming around pretty soon (: appreciate you looking into this

from telescope-file-browser.nvim.

fdschmidt93 avatar fdschmidt93 commented on May 27, 2024

Couple of things:

  • Proper steps to repro would be much appreciated -- thanks for reminding me that I have to put up an issue template
  • Creating a file just works differently than the file browser from telescope core because this extension uses vim.ui.input. You just press <C-e> and then vim.ui.input is triggered and works for me as expected in file and folder browser mode
  • Apologies, / is a currently undocumented input callback to move to folder browser mode as suggested upstream on the original PR.

worth pointing out that if I'm in file mode and hit / it will put me in folder mode so it seems to me that the only way to that this plugging has for creating a file may be a bit broken.

As mentioned in first thing on the README, this project is currently unstable. The file browser from core will only be deprecated in 19th of December. Hence, I'd welcome more constructive issues, rather than a vague description of what exactly it is you are doing in an expecting manner.

I'm closing this because I've retested it a couple of times and from what's described, it works as intended. Please let me know in case the above description doesn't work.

from telescope-file-browser.nvim.

j-hui avatar j-hui commented on May 27, 2024

@fdschmidt93 I just ran into that issue as well. It looks like vim.ui is not available on Neovim v0.5.1. I tested by running the following:

lua vim.ui.input({prompt = 'type: '}, function(i) print('typed: '..i) end)

This throws the exact same error on 0.5.1, but works as expected on another machine where I happen to have Neovim 0.6.0.

I'm personally looking forward to 0.6.0 to be released soon (or will just fix my machine running 0.5.1), but if the dependency on 0.6.0 is intentional, perhaps a warning could be given in the README?

from telescope-file-browser.nvim.

fdschmidt93 avatar fdschmidt93 commented on May 27, 2024

Many thanks for the constructive feedback!

Apologies, I'm on nightly and didn't keep in mind this is not part of 0.5.1 yet. Nevertheless, this should be quite easily fixed up until nvim 0.6 is released, which shouldn't be too far out.

Could you please confirm that

x = vim.ui and vim.ui input or vim.fn.input
print(x)

prints "<function 1>" (not sure about number) for you?

Then I'll push an easy intermediate fix.

E: ok it's a very annoying thing to fix 😆 since it requires a different implementation as vim.ui.input works with a callback as opposed to blocking the editor state like vim.fn.input, but I guess I'll have to do that.

from telescope-file-browser.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.