Giter VIP home page Giter VIP logo

Comments (6)

fdschmidt93 avatar fdschmidt93 commented on May 27, 2024 2

From the user perspective, what would change is the default path shown, which I think is a non-intrusive change.

Hence, I don't think we need to mirror behavior between file and folder browser here too closely. At the same time, fb_actions.create virtually has no utility (well I guess depending of config you could more easily create a file in cwd, which this change wouldn't obstruct). At the same time, this nicely makes depth=false a very sensible use case (see below).

Therefore, I'd say we should be practical and factor in this good suggestion.
I'm inclined to say that is how we should change move, copy, etc. as well. With depth=false, you could now turn the file browser into an enhanced find files and only select target directory through the folder browser.

from telescope-file-browser.nvim.

fdschmidt93 avatar fdschmidt93 commented on May 27, 2024 1

I'd be happy to, but a clean solution is quite a lot more complicated than you'd think.

What I would want to default to is putting the selection to the created file if possible (you eg can technically create file in file_browser mode not in the current folder).

Now, unfortunately that requires a lot of vim.schedule-ing gymnastics as we have to refresh the picker which is very async.

Why's that a problem?

Well, I'd want to support your use case with eg

["<A-c>"] = fb_actions.create + actions.select_vertical

as per upstream telescope, since I then don't have to make any assumptions how files are supposedly selected (or not) and it's the most maintainable.

The problem now is that that actions.select_vertical would have to await the scheduled fb_actions.create bit that puts the selection onto the newly created file.

It's probably easier/cleaner to circumvent picker:refresh and add straight to the finder's results, sort, and then set the selection in a synchronized fashion. But yeah, it's not that exciting work.

from telescope-file-browser.nvim.

jamestrew avatar jamestrew commented on May 27, 2024

This would be easy to implement.
However the question becomes would we want to mimic this new behavior for the File Browser as well. If we were to, I'm thinking we'd have to add ./ into the File Browser so people would be able to create a file in the current folder (and maybe also by selecting an existing file in the folder).

If we don't mimic it, the create function will have slightly different behaviors depending on which browser a user is on. I don't think I like that.

Won't this feature really only be saving people one press of the enter key? Is that really worth tinkering with how files are created right now? 🤷‍♂️
Maybe we can have it as an opt-in feature.

from telescope-file-browser.nvim.

danielnehrig avatar danielnehrig commented on May 27, 2024

very dope seeing this implemented now i can get rid of my makeshift version of this
big thanks

from telescope-file-browser.nvim.

danielnehrig avatar danielnehrig commented on May 27, 2024

could we implement a option which would open the newly created file in a buffer after creating ? @fdschmidt93

from telescope-file-browser.nvim.

danielnehrig avatar danielnehrig commented on May 27, 2024

Fair enough, I can see that

from telescope-file-browser.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.