Highlight definition can be slow and blocks cursor movement about nvim-treesitter HOT 8 CLOSED

#154 This fixes a lot of the slowness when I was testing. I will explore making the api async as well, but this is probably a good solution for now.

from nvim-treesitter.

Oh we can move that as an async method, to avoid blocking, maybe...
It will need to be cancellable though

from nvim-treesitter.

@vigoux What's the nvim/lua api for making this async? I can take a look at this.

from nvim-treesitter.

@steelsojka, I never used it personnally, but I think that the help page is located at :h lua-loop.

from nvim-treesitter.

I think we just wait for lua support for jobs. There is a PR for it in Neovim. I think it was called vim_wrap or something like that. Can give you hints tomorrow.

You would start the async job with a counter and only perform the highlighting when its finished when the counter was not incremented in the mean time. This is easier to implement that directly using vim.loop.

from nvim-treesitter.

Most of the performance issue is coming from checking if the node is a reference when recursing over the tree.

  M.recurse_tree(scope_node, function(iter_node, _, next)
    if vim.tbl_contains(references, iter_node) and M.get_node_text(iter_node)[1] == node_text then
      table.insert(usages, iter_node)
    end
    next()
  end)

I'll find a better way to check if it's a reference

from nvim-treesitter.

I'll also make it async as well 👍

from nvim-treesitter.

Is the issue still happening with latest master? If not, we will close this.

from nvim-treesitter.