Giter VIP home page Giter VIP logo

Comments (3)

clason avatar clason commented on June 17, 2024 1

Either is fine with me; it depends on what the plugins like nvim-treesitter expect. (The whole module has already been rewritten on the main branch, so this is purely for compatibility. As I personally don't use any of these plugins, I appreciate help from those that do.)

The (only) important change here is that the captures have been renamed to @local.foo to be compatible with upstream tree-sitter.

from nvim-treesitter.

clason avatar clason commented on June 17, 2024

PR welcome!

from nvim-treesitter.

leftas avatar leftas commented on June 17, 2024

@clason, I am more than happy to submit a PR, but I have a question then:

  • If the name implies that it iterates through locals, does it make sense to return inside β€œlocal” key (i.e. {["local"] = { reference = { node = { ... }}}}) or is it find_usages' responsibility, to deference the local. Given get_locals function and its usage, it seems that the latter should be the way to go. WDYT?

from nvim-treesitter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.