Giter VIP home page Giter VIP logo

Comments (8)

clason avatar clason commented on June 20, 2024

Deliberate. The capture names and highlight groups were standardized, which meant that the markers are no longer given a separate capture. If you want them, revert to the latest tagged commit, or re-add them in you personal config.

from nvim-treesitter.

polirritmico avatar polirritmico commented on June 20, 2024

Why the difference between headers marks and e.g. list markers?

from nvim-treesitter.

clason avatar clason commented on June 20, 2024

Because 1. list markers don't get a special highlight group and 2. you don't typically highlight list entries, so only list markers need a highlight.

from nvim-treesitter.

polirritmico avatar polirritmico commented on June 20, 2024

OK. From my user point of view, this seems like a regression, but as you pointed out, I could re-add them in my personal config.

Thanks for the explanation.

from nvim-treesitter.

clason avatar clason commented on June 20, 2024

It is a regression, but necessary (and justifiable) for maintainability.

from nvim-treesitter.

camoz avatar camoz commented on June 20, 2024

What is the long-term plan regarding this? Will some of the removed capture names (i.e. those that didn't get a replacement, like @text.title.*.marker.markdown) eventually be added upstream? Or is it expected that users solve this on their own, maybe through the emergence of new plugins that provide additional capture names and highlight groups for certain languages?

from nvim-treesitter.

clason avatar clason commented on June 20, 2024

You are welcome to add your own queries. There is no plan to change this, either here or in Neovim.

from nvim-treesitter.

polirritmico avatar polirritmico commented on June 20, 2024

For those who want this feature, this should bring back those highlights. In the nvim/after/queries/markdown/highlights.scm file:

;; extends
(atx_heading (atx_h1_marker) @markup.heading.1.marker)
(atx_heading (atx_h2_marker) @markup.heading.2.marker)
(atx_heading (atx_h3_marker) @markup.heading.3.marker)
(atx_heading (atx_h4_marker) @markup.heading.4.marker)
(atx_heading (atx_h5_marker) @markup.heading.5.marker)
(atx_heading (atx_h6_marker) @markup.heading.6.marker)

(setext_heading (setext_h1_underline) @markup.heading.1.marker)
(setext_heading (setext_h2_underline) @markup.heading.2.marker)

from nvim-treesitter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.