nzzdev / q-infographic Goto Github PK

Current

We serve lossless WebP allways: https://github.com/nzzdev/Q-infographic/blob/dev/helpers/images.js#L71-L72

Should

• Add new option serveLosslessWebP defaulting to false
• Serve images with lossy WebP: change webpll to webply for the fastly parameter
• Only if the option serveLosslessWebP is true, serve webpll

This does not need any migration for existing graphics. If one finds one that has problems with lossy, one can enable the option.

The dependency uglify-js was updated from 3.6.1 to 3.6.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

uglify-js is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The dependency @hapi/inert was updated from 5.2.1 to 5.2.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@hapi/inert is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

There should be a - between notes and Grafik:

The dependency @hapi/hapi was updated from 18.3.2 to 18.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@hapi/hapi is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Task

We made changes to the configuration format of dynamicEnums and availabilityChecks. The schema and corresponding routes need to be adjusted as following (more details on the config format can be found here):

DynamicEnums

Current:

"dynamicEnum": {
  "type": "ToolEndpoint",
  "withData": true,
  "endpoint": "dynamic-enum/selectedColumn"
}

New:

"dynamicEnum": {
  "type": "ToolEndpoint",
  "config": {
    "endpoint": "dynamic-enum/selectedColumn",
    "fields": ["options", "data"]
  }
}

Additionally the /dynamic-enum now receives an object containing the item and optionally and options property. The route needs to be adjusted to this.

AvailabilityChecks

Current:

{
  "type": "ToolEndpoint",
  "withData": true,
  "endpoint": "option-availability/invertColors"
}

New:

{
  "type": "ToolEndpoint",
  "config": {
    "endpoint": "option-availability/invertColors",
    "data": ["options", "data"]
  } 
}

Additionally the /option-availability now receives an object containing the item and optionally and options property. The route needs to be adjusted to this.

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet.
We recommend using:

• CircleCI
• Travis CI
• Buildkite
• CodeShip
• Azure Pipelines
• TeamCity
• Buddy
• AppVeyor
  But Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

The devDependency amphtml-validator was updated from 1.0.23 to 1.0.24.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

amphtml-validator is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The alt attribute needs to be added to the img tag here: https://github.com/nzzdev/Q-infographic/blob/dev/views/images.html#L5

it should contain:

• the title of the Q-item if displayOptions.hideTitle is not true followed by a -
• followed by the subtitle of the Q-item

If displayOptions.hideTitle is true and the subtitle is empty, the alt attribute should be omitted.

The spacing between notes and sources is too big: