Giter VIP home page Giter VIP logo

shadcn-virtualized-combobox's People

Contributors

oaarnikoivu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

shadcn-virtualized-combobox's Issues

Props/State data duplication

Hi, thank you for the example!

I just made quick code review and I think you should't duplicate the "option" prop to the state like you have in the example

const [filteredOptions, setFilteredOptions] =
    React.useState<Option[]>(options);
  const parentRef = React.useRef(null);

You can just store value of the search input in state and filter options from prop and store them in the constant like this

const [inputValue, setInputValue] = useState(``)
  const records = dataset?.records
  const filteredRecords = useMemo(
    () =>
      records?.filter((record) => {
        const value = getPrimaryPropertyValue(record)
        return value?.toLowerCase().includes(inputValue?.toLowerCase())
      }),
    [records, inputValue],
  )

...

<CommandInput value={inputValue} onValueChange={setInputValue} />

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.