oazabir / aspectf Goto Github PK

I've been using the library and notice the duration wasn't captured correctly.

I make the change the method HowLong() of DataTime start to use UniversalTime 
so I could capture the correct duration.

Line 143 in AspectF.cs reads:
Retry(1000, 1, (error) => DoNothing(error), x => DoNothing(), work, logger));

It must be like this:
Retry(1000, 1, (error) => DoNothing(error), failHandler, work, logger));

What steps will reproduce the problem?
1. If using Let.Us and calling multiple aspects such as TrapLog or calling the 
same method again.
2. See the stack trace of method calls. There are numerous anonymous method 
called
3. The reason maybe that there is a combine defined. But there is no way to 
clear the combined Actions when new call is made.

What is the expected output? What do you see instead?
The stack trace should have as many anonymous methods as the number of chain 
calls.

What version of the product are you using? On what operating system?
Latest checkin as on 3/2/2011

Please provide any additional information below.

What steps will reproduce the problem?
1. AspectF.define.HowLong(Logger, "Start", "Stop {3}{2}{1}{0}).Do
(()=>Thread.Sleep(2000);))};

What is the expected output? What do you see instead?
Expected Stop 00:00:05.6088365
Instead: Stop -00:59:57.2658875

What version of the product are you using? On what operating system?
1.3

Please provide any additional information below.
Correct
DateTime start = DateTime.Now();
to
DateTime start = DateTime.Now.ToUniversalTime();
?

Break out Test class from Aspect core class so its reusable.

The Until extension method in 1.3 hasn't been updated like the While extension 
method has. The While extension method does what it says it does which is 
execute the Do while the condition is true, but the Until method loops while 
the condition is not true (not executing the code) and then then executes the 
Do code once.

The Until extension method needs to be brought into line like the While 
extension method was.



        [DebuggerStepThrough]
        public static AspectF Until(this AspectF aspect, Func<bool> test)
        {
            return aspect.Combine((work) =>
            {
                do
                {
                    work();
                } 
                while (!test());
            });
        }

        [Fact]
        public void TestTrapLogThrow()

fails with at the Moq Logger