Comments (7)
I can mentor on this issue.
from cargo-semver-checks.
To answer the original question,
Since we must respect the color choices set in various ways (as described in anstyle-query
), we must bring in anstream
. And then have a generic output function that uses anstyle-termcolor
to convert the termcolor
usage to anstyle
before printing. This is the way people would choose to migrate if they have a lot of places where they need to migrate.
But since, we have only a few places and also use termcolor_output
to currently print that we can't easily modify, and we are bringing in anstream
anyway, I would recommend the refactor to anstream
crate completely.
(Feel free to ping me on Zulip if you want to chat)
from cargo-semver-checks.
If you want to do that, I would recommend tracing
instead (setup and usage)
from cargo-semver-checks.
Hi! Thanks for the offer to help! Would common practice be to use the anstyle-termcolor
crate or refactor entirely to use the anstream
crate?
from cargo-semver-checks.
I might be wrong but I consider anstyle-termcolor
to be more related to style customization logic.
The color logic we need to clean up here is more about the setup including respecting user's preferences. I have a sample boilerplate for CLIs that sets up everything related to color at https://git.sr.ht/~pksunkara/cli-clap.
There are quite a few important parts such as:
- Reading
--color
argument, https://git.sr.ht/~pksunkara/cli-clap/tree/master/item/src/main.rs#L38 - Forwarding color choice to logging, https://git.sr.ht/~pksunkara/cli-clap/tree/master/item/src/main.rs#L45
- Outputting text while respecting color choice, https://git.sr.ht/~pksunkara/cli-clap/tree/master/item/src/hello.rs#L24
from cargo-semver-checks.
just a thought while I work on this - does it make sense to also refactor to use something like the log
crate for managing log levels?
so that the end application (the cli for us, and whatever binary crate uses semver-checks
) sets color and logging preferences, and the library part of the crate is less aware of these preferences
from cargo-semver-checks.
Added in #737
from cargo-semver-checks.
Related Issues (20)
- Cargo semver checks ignores my lockfile HOT 8
- Running scripts on systems with bash version older than v4 causes errors HOT 3
- Notice if a run is going to be a no-op before generating rustdoc JSON
- False-positive "enum variant added on exhaustive enum" HOT 2
- Verbose runs should show which features were enabled in the crate versions being tested HOT 4
- Unable to enable dependency's features needed to build the crate HOT 6
- Build failure repro command may include `--features` flag without any features
- Support flags like `--color=always` and `--color=never`
- Improve error message when no library targets are found HOT 1
- Check if trait items with defaults may need special handling to avoid false-positives HOT 5
- Make the `make_new_lint.sh` script avoid merge conflicts when registering the new lints
- Consider either testing that lint file names match their `id` fields, or removing the field entirely.
- Add "Media coverage" section to the README, with relevant talks, podcasts, blog posts, etc.
- Support [term] configuration in Cargo config.toml for color and logging HOT 3
- `RustdocCommand` progress (when `silence` is `false`) does not respect configured `stderr`
- Check lints related to trait implementations for false-positives if the trait impl is `#[doc(hidden)]`
- Configuration methods do not have consistent naming HOT 3
- Refine lints about field and method removals to account for `Deref/DerefMut`
- `cargo semver-checks` takes much longer after upgrading to version 0.30.0 from 0.24.1 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-semver-checks.