Comments (3)
suaviloquence
commented on June 30, 2024
1
I can do that. One other thing: do we want to standardize the calling convention? Currently only set_level takes an owned Self (and it doesn't use it, we could use a &mut self). If we copy the Check convention, setter methods go fn(&mut self, ...) -> &mut self which I think makes a lot of sense.
from cargo-semver-checks.
obi1kenobi
commented on June 30, 2024
Sounds good, let's go with that!
Probably best to make this change now, before the next release, so that we only break the API once. Would you mind posting the updated migration guide together with the PR?
from cargo-semver-checks.
obi1kenobi
commented on June 30, 2024
Sounds good to me!
from cargo-semver-checks.
Related Issues (20)
- Notice if a run is going to be a no-op before generating rustdoc JSON
- False-positive "enum variant added on exhaustive enum" HOT 2
- Verbose runs should show which features were enabled in the crate versions being tested HOT 4
- Unable to enable dependency's features needed to build the crate HOT 6
- Build failure repro command may include `--features` flag without any features
- Support flags like `--color=always` and `--color=never`
- Improve error message when no library targets are found HOT 1
- Consider switching to `anstyle` for our terminal styling and color needs HOT 7
- Check if trait items with defaults may need special handling to avoid false-positives HOT 5
- Make the `make_new_lint.sh` script avoid merge conflicts when registering the new lints
- Consider either testing that lint file names match their `id` fields, or removing the field entirely.
- Add "Media coverage" section to the README, with relevant talks, podcasts, blog posts, etc.
- Support [term] configuration in Cargo config.toml for color and logging HOT 3
- `RustdocCommand` progress (when `silence` is `false`) does not respect configured `stderr`
- Check lints related to trait implementations for false-positives if the trait impl is `#[doc(hidden)]`
- Refine lints about field and method removals to account for `Deref/DerefMut`
- `cargo semver-checks` takes much longer after upgrading to version 0.30.0 from 0.24.1 HOT 2
- Breakage related to `where Self: Sized` bounds on trait associated types and methods HOT 6
- Fail if crates.io has the same version as in Cargo.toml HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-semver-checks.