obsidian-community / obsidian-pandoc Goto Github PK

Have there been any updates to this plugin?

And I'm still having issues when I try to convert a file to OpenDocument (but probably also other formats) with images. I get the following error message, I assume it means that pandoc can't find the image?

Thanks!

The fork here is a little confusing. I understand why it exists, but is this codebase now where the Community plugins UI is pulling from, or do I need to manually install this version?

I think if this switch is happening, it should probably fully happen, ie. the community plugins should point to this repo, the readme links should be updated to point here instead of at the old repo, etc.

If this is welcome I can probably do this myself and submit a PR, but I want to coordinate about it first.

perhaps it's the unicode used..

![[🚩 - ✅ Yoshi]]

renders as [[🚩 - ✅ Yoshi]]

The standard Export to PDF doesn't have this issue. But it seems like all of the Pandoc plugins fail at this. I was hoping to be able to export to Docx due to business needs.

I think I found a quite bad bug, but I want other eyes on it to verify.

There is a setting in the plugin that allows the user to input their own custom path for pdflatex, in case it's not accessible on the user's PATH.

The code that spawns the pandoc process tries to use this path in the following way:

1. Make a copy of the process.env object:
   

   obsidian-pandoc/pandoc.ts

   Line 149 in c8cf21a

   const env = Object.assign(process.env);

2. If a custom pdflatex path is provided, update the copied env object with that new path:

   obsidian-pandoc/pandoc.ts

   Line 159 in c8cf21a

   env.PATH += path.dirname(input.pdflatex);

3. Totally ignore the modified copy, and just pass in the normal process.env anyway:

   obsidian-pandoc/pandoc.ts

   Line 161 in c8cf21a

   pandoc = spawn(input.pandoc || 'pandoc', args, { env: process.env });

So the custom pdflatex path is actually never used, and the only way this plugin can ever generate pdfs is if pdflatex actually is on the user's PATH.

I think the fix is simply to change line 161 to:

pandoc = spawn(input.pandoc || 'pandoc', args, { env: env });

Thoughts?

When the plugin checks for features one of the checks is does is whether the target output type needs pdflatex to run. That check is exactly:

In other words, the plugin will not generate any pdfs unless pdflatex is also installed.

I suspect this is wrong and that many pdfs can be generated without pdflatex, but I don't know the details and might be wrong.

If I'm not wrong, I'm not sure how to fix it. We need a way to detect whether a particular file needs pdflatex to convert, but I don't know what that check would look like.