Comments (9)
the issue here is that do_common will read gsl_include.sexp
at init time (IO happens outside of a function), so running do_sf.exe will read that file. The correct fix is to add gsl_include.sexp
as a dependency to force an ordering in the dependency graph. otherwise, this will depend on the order in which the modules of the library are built: if Sf
is built before Cdf
or Const
, it will fail. It's true that -j 1
will prevent rules from firing in parallel but dune can not guarantee anything about the order in which the modules are built. This has probably changed several times between dune versions.
from opam-repository.
Mmh, I can't reproduce it locally and it was supposed to be fixed by #19244
Is this deterministically reproducible with your setup?
from opam-repository.
It is strange. It seems deterministically reproducible when I (try to) install all these packages (except ppx_globalize) at once in an empty 4.13.1 switch. However, installing orpie alone in an empty switch, or installing it after all the others are installed, succeds.
from opam-repository.
I've tried to reproduce locally with all those packages at once but it worked for me
from opam-repository.
I just remembered that I applied a patch in Debian. A similar fix was applied upstream, but not released yet. A kind of race condition does exist in the package in its current form. Maybe the patch should be applied in the opam package as well?
from opam-repository.
I was under the impression that dune build -j1
(from #19244) would be an alternative fix for this. Does -j
not make the build order deterministic in dune? cc dune devs @rgrinberg @emillon @Leonidas-from-XIV @gridbugs
from opam-repository.
This has probably changed several times between dune versions.
ah, I see. Very unfortunate. Thanks a lot!
@glondu could you open a PR to add your patch to the relevant versions? (and maybe restore "-j" jobs
at the same time)
@mmottl could you do a release when you have some spare time?
from opam-repository.
I mean, on the other side I can't tell you for sure it has changed, but the build engine has changed enough that I'd say this kind of thing is likely to have changed.
from opam-repository.
With the introduction of background threads, not even -j 1
guarantees a deterministic order of actions. There's some environment variables to disable the various background threads if this desirable.
from opam-repository.
Related Issues (20)
- Opam repository API HOT 2
- ocamlgraph.1.8.8 - moved to new address HOT 2
- OCaml 5.2.0 Release Readiness HOT 3
- Invalid_argument("OpamEnv.unzip_to") opam error after installing conf-openblas HOT 2
- opam switch create dune fails on WSL: "undefined reference to `pthread_join@GLIBC_2.34'"
- Unable to install conf-gmp on Arch Linux with Homebrew HOT 3
- MacOS,Arm: conf-mpfr-paths does not install HOT 4
- css checksum changed and is not installable currently HOT 15
- ocaml lru cache changed signature HOT 3
- The compilation of conf-gmp.4 failed at "sh -exc cc -c $CFLAGS -I/usr/local/include test.c". HOT 1
- make old dune versions unavailable on win32 HOT 1
- iri 0.6.0 checksum changed
- easy format 1.0.1 is broken HOT 2
- policy question with respect to data races in opam packages and OCaml 5 upper bounds HOT 2
- merlin packages incompatibilities
- Error installing conf-lapack in ALPINE HOT 3
- `ocaml-base-compiler` compilation error
- Dune compilation error "fatal error: CoreFoundation/CoreFoundation.h: No such file or directory"
- Update wyrd upstream URL and version HOT 3
- mad >=0.5.0 won't install on FreeBSD due to pkg-config looking for mad rather than libmad HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opam-repository.