Comments (6)
monnier
commented on September 17, 2024
What would be needed to use the indentation engine tuareg provides in another major mode?
Hard to know without trying but at least:
- Load `tuareg.el` into Emacs.
- Set `indent-line-function`.
- Make sure the syntax-table used is the same as that of `tuareg-mode`.
- Probably set `syntax-propertize-function` as well.
The use case is using the indentation engine with `ocaml-ts-mode`.
Count me baffled, since I thought the main benefit of TreeSitter is for indentation.
A similar case is `python-ts-mode`, which uses `python-indent-line-function`
for indentation in `python-ts-mode` instead of using treesitter
for indentation.
I haven't looked at `python-ts-mode` but at least Python's
indentation-significant syntax gives me a good reason to think that it
might be "unusual". Can't think of any reason why OCaml's indentation
wouldn't benefit from an actual AST like the one Tree Sitter
can provide. Is it that Tree Sitter's OCaml grammar sucks?
from tuareg.
KaranAhlawat
commented on September 17, 2024
- Set
indent-line-function.
For this, I wasn't really sure how to set theindent-line-functionsincetuareg-modeseems to be wrapping the existing function in an advice only. But where does the existing function come from in the first place?
Count me baffled, since I thought the main benefit of TreeSitter is for indentation.
It's not that it can't be used for indentation, but quite a few users of Tuareg mode like it's indentation engine, and I'd like to save some duplicated effort if possible (read: I'm being a bit lazy).
Can't think of any reason why OCaml's indentation wouldn't benefit from an actual AST like the one Tree Sitter can provide. Is it that Tree Sitter's OCaml grammar sucks?
I don't think the grammar sucks (from my experiments with it). But, isn't Ocaml a little leaning to indentation based syntax as well? For example, if you have multiple let bindings in a file, you can define them without a;;. Anyways, I digress.
If you can help me figure out the indent-line-function I think we might be going somewhere
from tuareg.
monnier
commented on September 17, 2024
> \- Set `indent-line-function`.
For this, I wasn't really sure how to set the `indent-line-function` since
`tuareg-mode` seems to be wrapping the existing function in an advice
only. But where does the existing function come from in the first place?
It's set by `smie-setup`.
> Count me baffled, since I thought the main benefit of TreeSitter is for indentation.
It's not that it can't be used for indentation, but quite a few users of
Tuareg mode like it's indentation engine, and I'd like to save some
duplicated effort if possible (read: I'm being a bit lazy).
As the "main" original author of that indentation code, I'm happy to
hear it, but it would be nice to try and reproduce its behavior
using Tree Sitter.
I don't think the grammar sucks (from my experiments with it). But, isn't
Ocaml a little leaning to indentation based syntax as well? For example, if
you have multiple let bindings in a file, you can define them without
a `;;`. Anyways, I digress.
It can feel a bit magical, indeed, but this is disambiguated without any
recourse to indentation information. 🙂
from tuareg.
KaranAhlawat
commented on September 17, 2024
Oookay, so, I was able to set it up and it works pretty much the same as tuareg-mode, but the rest of the mode is enhanced by tree-sitter (syntax highlighting, imenu, usage with third party packages such as combobulate, textobjects etc etc).
If I find free time over the weekend, I'll try to add some indentation using tree-sitter itself, we can compare which one feels nicer overall.
from tuareg.
monnier
commented on September 17, 2024
Oookay, so, I was able to set it up and it works pretty much the same as
`tuareg-mode`, but the rest of the mode is enhanced by `tree-sitter` (syntax
highlighting, imenu, usage with third party packages such as combobulate,
textobjects etc etc).
👍🏾
If I find free time over the weekend, I'll try to add some indentation using
tree-sitter itself, we can compare which one feels nicer overall.
That will compare your Tree Sitter indentation rules to the SMIE
indentation rules, rather than comparing Tree Sitter to SMIE.
IOW, which is better will largely depend on which one got more effort
put into it.
from tuareg.
KaranAhlawat
commented on September 17, 2024
We can close this now, thank you so much for your help :)
from tuareg.
Related Issues (20)
- Unbind `C-c ?` and `C-c C-h` (maybe) HOT 22
- Can't run Ocaml REPL HOT 3
- Find alternate file doesn't seem to care about tuareg-other-file-alist HOT 1
- Possible bug : missing file tuareg-compat HOT 3
- 3.0 version not tagged HOT 8
- Package cl is deprecated HOT 2
- Tuareg depends on emacs-nox HOT 3
- Triggers warning for using obsolete aliases on Emacs HOT 5
- Target newer Emacs version HOT 8
- outline mode
- Document the differences between tuareg and caml-mode HOT 5
- Completion in the *OCaml* buffer HOT 3
- tuareg.3.0.0 fails to load in emacs on macOS when installed using opam HOT 1
- How does one jump to definition? HOT 3
- Add configuration option(s?) to make highlighting behave closer to what it was like in 2.2 . HOT 2
- Use tree-sitter HOT 1
- tuareg-current-fun-name returns inaccurate results, breaking which-function-mode
- create a custom variable for process-connection-type HOT 4
- Adding parentheses changes indentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tuareg.