oceanobservatories / mi-instrument Goto Github PK

Hello! I just stumbled across this repository. It appears to contain a lot of code for reading data from oceanographic instruments that might be really useful. (Is this correct? I couldn't quite figure it out from the readme)

I am trying to figure out if it is possible to use this package for simple tasks that observational ocenaographers need to perform. For example, could I use it to load a raw data file from a Teledyne RDI ADCP and rotate the coordinate system? Could I read raw data from RBR or Seabird CTDs?

While parsing a data burst, the inner loop consumes a line at a time and tests if it matches the sensor data format. If it does not, the data burst is over, so the new particle is emitted, and the function jumps back to the top o the outer loop to start looking for the next data burst.

However, that line has now been consumed and cannot be read again by the outer loop. If the discarded line is the header of the next data burst, parsing will fail.

In existing logs, the DCL happens to be recording power state messages between data bursts, and these can be safely skipped. However it is fragile to expect this and in the near future these messages will not be present in some logs.

Wondering if there's a plan to make the code compatible with py 3?

Hi, I am wondering if you'll be interested in user submitting changes to code for specific instruments. I've been working on zplsc_b data and added additional functions to allow calibration of the power data unpacked from .raw in my fork. I am using the fork as a submodule in my other repo now, but wonder what is the preferred path forward. Also wondering what license the code is under, I saw a license file in the top level but the zplsc_b code uses Apache 2.0? Thanks!