[Testsuite] too much recursion about eliom HOT 24 CLOSED

please give js_of_ocaml version and options . Could be related to recent changes in js_of_ocaml

from eliom.

I don't have such information (as it's a devel package installed through opam), but I'll try with the latest version.

from eliom.

Some thing with the latest js_of_ocaml.

from eliom.

I cannot reproduce this with eliom/master + js_of_ocaml/master. What browser do you use ?

from eliom.

Firefox 27.0.1. Is that the page reloads when you click several times on the links ? For me, with the same test case (out of the testsuite) the page doesn't reload the first time but the second restarts the application.

from eliom.

I don't see any Too much recursion.
I don't see any page reload (when clicking several time on links).
However, the page does not to update anymore after I switch between templates (tpl1 -> tpl2 or tpl2 -> tpl1).
Can you give more details ? console trace ? what "test case (out of the testsuite)" are you talking about ?

config : firefox 30.0a1 and chrome 33.0.1750.146

from eliom.

The test « out of the testsuite » I made is the following:

{shared{
  open Eliom_lib
  open Eliom_content
  open Eliom_content.Html5
  open Html5.D
}}

module My_appl =
  Eliom_registration.App (
    struct
      let application_name = "test"
    end)

let tmpl1_update id contents = {{
  debug "Update";
  Eliom_client.onload
    (fun () ->
      Html5.Manip.Named.replaceAllChild %id %contents)
}}

let content_id = Html5.Id.new_elt_id ()

module Tmpl_1 = Eliom_registration.Eliom_tmpl(My_appl)(struct
  type t = Html5_types.flow5 Html5.elt list
  let name = "template_one"
  let make_page contents =
    Lwt.return
      (Eliom_tools.F.html ~title:"test"
          (body [Html5.Id.create_named_elt ~id:content_id (div contents)])
      )
  let update  = tmpl1_update content_id
end)

let main_service =
  Eliom_service.App.service ~path:[] ~get_params:Eliom_parameter.unit ()

let () =
  Tmpl_1.register
    ~service:main_service
    (fun () () -> ignore {unit{ debug "test"; }};Lwt.return [a ~service:main_service [pcdata "link"] ()])

There is no more console messages in the testsuite apart from this one if I click on the « Click me » buttons:
ReferenceError: caml_closure_idAJjKyq is not defined

from eliom.

What is the status of this ?
I never managed to reproduce any of this ..

from eliom.

@jpdeplaix ??

from eliom.

I currently testing. The errors seems to have disappeared but if I click twice on the link, the page reloads. I tested with the latest eliom.

from eliom.

cannot reproduce the reloading issue !!
do you actually see a different value for Random value in the container when you experience the reload ?

from eliom.

Yes, data-eliom-node-id changed the second time but not the first one.

from eliom.

data-eliom-node-id ? witch one ? there are many in the page ..
does someone else manage to reproduce this bug ?

from eliom.

The first one at least (on the body tag)

from eliom.

Aren't we taking about pages tmlpX/pageX ? There is no data-eliom-node-id attribute in the body elt !!!

from eliom.

No, I'm talking about the above test-case :/

from eliom.

title and first comment updated to make things clear

from eliom.

I just tested and I still have the too much recursion problem for the testsuite.

from eliom.

where ? can you give a precise step-by-step description ?

from eliom.

I've opened a new issue #85, for the reload issue

from eliom.

• Launch the testsuite
• Go to the main page
• Open the web console
• Click on Multiple template switching.

At least for me, I get a « too much recursion » after these steps.

from eliom.

unable to reproduce under OSX.10.9.2 with:

• firefox : 29.0.1
• firefox : 32.0a1 (2014-05-18)
• chrome : 35.0.1916.114

from eliom.

(Tested with Firefox/Iceweasel 29.0.1 for me)

from eliom.

in client2/eliom_client.js, we have:

v[d][v[d].length-1][2] == late_unwrap_mark

That should be ===.

The value in v is turned into a string to compare it with late_unwrap_mark. As the value is too large, we get a stack overflow...

from eliom.