DomReact : Wrap tyxml elt with ReactiveList instead of React.S about eliom HOT 8 CLOSED

Can you motivate the change a little more ? Wouldn't it touch only the internal, not making a big change for the user ? Would it be more efficient ?

from eliom.

the difference with the current implementation is that it patches lists instead of updating the whole value.

Imaging having a live chat with 1000+ msgs. Using react with the current implementation would recompute every msgs at every insertion.

With reactive list, you only apply patches and in the end patch the dom (https://github.com/hhugo/reactiveList/blob/master/src/reactiveDomList.ml#L11)

• It is more than an "internal" change.
• more efficient : the efficiency is not the point but yes => you compute one element only at insertion

from eliom.

Ok, that's what I though, thanks.
And according to your description, efficiency is exactly the point. :p

Can we make this a not-to-breaking change and wait for 4.1 ?

from eliom.

as discussed with @balat, this will not be part of 4.0 and will wait 4.1 !
If you want to try to implement this without breaking the interface, please try. But as I said before, I think this change is about interfaces and not about performances.
The fact that it does not rebuild unneeded element is not only performances. It's about not touching dom that don't change (ie: keep your text selection, keep an onmousedown, ..)

from eliom.

Ok, I see your point more clearly now.

We should make it clear in the documentation that the R modules is WIP and will change a bit then.

from eliom.

This change will require an update to the tyxml interface to provide different wrappings (one for attribute, one for element list).
Also we might have an issue with plus / plus_concat (ie TABLE)
What will be the meaning of a reactive TABLE wrt the non-emptiness.

from eliom.

related work : "Higher-Order Reactive Programming with Incremental Lists"

from eliom.

merged

from eliom.