odigeoteam / tableviewkit Goto Github PK

It would be good to improve how we are managing the animation, also a way to customise it.
Apart from the standard UITableView animations. Something similar to UIViewControllerTransitionCoordinator?

It would be nice to have a better explanation of the StaticStateful protocol

This issue is for tracking any improvements on our examples.
It would be nice to have a .playground example to show off the features of the framework.

When calling the method
public func reload(with animation: UITableView.RowAnimation = .automatic)
it looks that the parameter animation is being ignored of. If you set, for example, animation .left in the TableViewManager and try to reload an item with animation .top, the item reloads but with .left animation

Documentation MUST be added ASAP.

Validator should not be part of our core.
It would be nice to provide a "plug" extension into our core. Maybe these interface could be shared with #3

What if we create an adapter for managing empty state tables?

This is the scenario: you have two instances of the same type of item which is (in this case) conform to the Equatable protocol and you want to replace using the method items.replace(with:.
Pay attention because the manager of the new Item is properly set but you lose the reference of the old one. If you have some kind of logic in order to use the manager of the old one you will have item?.manager = nil.

Call the draw method inside tableView:willDisplayCell:forRowAtIndexPath: method instead tableView:cellForRowAtIndexPath: method.

Don’t perform data binding at tableView:willDisplayCell:forRowAtIndexPath: method, because there’s no cell on screen yet. For this you can use tableView:willDisplayCell:forRowAtIndexPath: method which can be implemented in the delegate of UITableView. The method called exactly before showing cell in UITableView’s bounds.

What do you think?

It seems to register every cell regardless the type, which seems to break the prototype reuse.

ActionBar and ActionBarDelegate should not be part of our core.
This issue will also help to understand if changes are needed in order to be more open to external implementations.

headerTitle not properly displayed, attached an example of the problem by @ndleon09
TableViewKit+VIPER.zip