oefenweb / ansible-dnsmasq Goto Github PK

Using multiple lines for the ansible_managed variable causes an error when the template files are validated. Specifically, the first line of the file will be commented out, but every subsequent line of the ansible_managed variable will be written to the config files as-is.

Proposal: Use Ansible's built-in comment filter to template out the comment.
Instead of

# {{ ansible_managed }}

the line should read

{{ ansible_managed | comment }}

The comment filter can handle multiline strings without a problem.

Hi,

Thank you for this role! I am loving how simple it is to use it and how flexible it is. Unfortunately, I am getting the following warning when using it and I would love if this kept working in the future:

TASK [oefenweb.dnsmasq : install dependencies] ********************************************************************************************************************************************************
[DEPRECATION WARNING]: Invoking "apt" only once while using a loop via squash_actions is deprecated. Instead of using a loop to supply multiple items and specifying `name: "{{ item }}"`, please use 
`name: '{{ dnsmasq_dependencies }}'` and remove the loop. This feature will be removed in version 2.11. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

Is there a way to fix this in a future version?

All the best,
Christophe-Marie

The role installs and configures dnsmasq in a debian-like system but it could be very useful if we could run this role for a redhat-like system.

Thanks.

I'm looking for a way I can append DNSMASQ_EXCEPT=lo to /etc/default/dnsmasq

I imagine adding variable like dnsmasq_etc_default_options: []

Any thoughts?

I have a chicken and egg situation where systemd.resolved needs to be disabled before running this role, but doing so stops it from being able to apt install dnsmasq (repo fails to resolve).

It would be nice to have the role take care of this:

1. install dnsmasq
2. disable systemd.resolved
3. (re)start dnsmasq