Simulation-object for solve-method of optimizationmodel not working from outside energysystem class about oemof-solph HOT 7 CLOSED

It might be a bit off-topic but I have just adjusted the storage_optimization example came across the following:

simulation = es.Simulation(timesteps=timesteps, stream_solver_output=True,
                           objective_options={
                               'function':predefined_objectives.minimize_cost})

energysystem = es.EnergySystem(entities=entities, simulation=simulation)
energysystem.year = 2010

om = OptimizationModel(energysystem)
om.solve(solver='gurobi')

The simulation object and direct passed parameters are still co-existing. We should go one way and fix it in the next version.

from oemof-solph.

I disagree, both way should stay possible. That's what this issue is for. If one uses simulation object - fine if not use solve() method and pass parameter. Or use simulation object for some options and adjust when calling solve().
But the simulation-object attributes should be passed to solve() method in every case. This is only true for the use of optimize() method from the energysystem class.
Actually setting the attribute 'stream_solver_output' at the example above should not change anything at the moment because it isn't implemented this way...

from oemof-solph.

Convinced

from oemof-solph.

I actually checked today in the storage example and solver output is not streamed due to the 'bug' even if it's set at the attribute of simulation object....

from oemof-solph.

I set the milestone to January release, is this realistic ? @gnn

from oemof-solph.

I can go ahead with this one @gnn

from oemof-solph.

I fixed the bug for now, it is not perfect, but i works as intended. Now the simulation object attributes are taken if the solve() method does not have any...

from oemof-solph.